From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sun, 1 Nov 2015 12:20:19 +0000 Message-ID: References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <20151031233225.GD1853@acm.fritz.box> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1446380449 31357 80.91.229.3 (1 Nov 2015 12:20:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Nov 2015 12:20:49 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Stefan Monnier , emacs-devel To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 01 13:20:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zsrcq-0004af-0A for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 13:20:44 +0100 Original-Received: from localhost ([::1]:36603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsrcp-00078p-3v for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 07:20:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrcU-00078j-7k for emacs-devel@gnu.org; Sun, 01 Nov 2015 07:20:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsrcT-0008OO-DV for emacs-devel@gnu.org; Sun, 01 Nov 2015 07:20:22 -0500 Original-Received: from mail-lb0-x236.google.com ([2a00:1450:4010:c04::236]:33182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsrcT-0008OK-6n for emacs-devel@gnu.org; Sun, 01 Nov 2015 07:20:21 -0500 Original-Received: by lbbec13 with SMTP id ec13so73204800lbb.0 for ; Sun, 01 Nov 2015 04:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=oqqDsOw06OF26PadytXOHq3Ey9yelWIirs7YiAkzHLE=; b=wwkjsnaXNauNVwLz0QXPMJNHVu9mpoleEr25rgIv3nHXPOpmUIAB8x1W3MAf4PfHJh BdspcvZxpxSqGV1cfd2C4h+O+GGdjRUSI1rQG5duPGYkPfeFuTToZmiCDo4FGESDBibr Gx++wkmygI8hwajieZgSkXNR4JQ/Oami0veQr1qSPZpmEd7dZM5sREOadxzdjbBVs4GY XXTzkW6sG7DSVnYPcGLBYnYPvmTHZV5dClptOrUM9XzPK8EyZ3wImVPXOBxQz8U5035D SBc5ab97XiH0qrIhA0F0m9YEsStRguK61gTqAzTWR2NQxMjke4KxAY3rh8fhtviCqA5o d7oQ== X-Received: by 10.112.135.233 with SMTP id pv9mr7928300lbb.42.1446380419986; Sun, 01 Nov 2015 04:20:19 -0800 (PST) Original-Received: by 10.112.63.71 with HTTP; Sun, 1 Nov 2015 04:20:19 -0800 (PST) In-Reply-To: <20151031233225.GD1853@acm.fritz.box> X-Google-Sender-Auth: 9stkvly6kqbCFWCvQSSMYE76v24 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193059 Archived-At: Hi Alan, >> What if isearch just took into account all windows displaying >> current-buffer, instead of just the selected one? >> This wouldn=E2=80=99t involve anything specific to follow mode, and I be= lieve it >> would solve the issue, no? > > I don't think so, really. What exactly does "took into account" mean? > With Follow Mode active, on a forward search you explicitly want point to > move into the next window when the search target is visible there. When > FM is not active, you most definitely don't want this to happen. Well, one of the reasons I suggested it is because I think I actually would want that. But, of course, it would be conditioned on a variable (disabled by default), and follow-mode would simply have to enable it. > I have working code which make isearch and FM work together nicely. I > think it's a sufficiently "nice" implementation to commit. Sure. Don't take this as me trying to push you in a different direction. I brought it up because it sounded like it would be simpler. You have a better understanding of the issue and the code than I do, don't feel obliged to try my suggestion.