From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Kaushal <kaushal.modi@gmail.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 23038@debbugs.gnu.org
Subject: bug#23038: 25.0.92; M-% from isearch broken (error in isearch--describe-regexp-mode)
Date: Fri, 18 Mar 2016 00:53:49 -0300 [thread overview]
Message-ID: <CAAdUY-K6U5qT0nEiB8HJB3h9KhHEozk5hHXMuftJhgcxJhGWuw@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY2ynb0bkV+ZtS4gJPTRy=qWAWXbZz1euQwb2Q4dcHXHug@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
On 17 Mar 2016 11:26 am, "Kaushal Modi" <kaushal.modi@gmail.com> wrote:
>
> I would let you and others evaluate this proposed fix.
>
> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index 988503e..9b8a0f0 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -2594,7 +2594,8 @@ isearch--describe-regexp-mode
> (isearch-regexp "regexp ")
> ;; 4. And finally, if we're in literal mode (and if the
> ;; default mode is also not literal), describe it.
> - ((functionp search-default-mode) "literal "))))
> + ((functionp search-default-mode) "literal ")
> + (t ""))))
> (if space-before
> ;; Move space from the end to the beginning.
> (replace-regexp-in-string "\\(.*\\) \\'" " \\1" description)
Thanks Kaushal! It looks good to me.
[-- Attachment #2: Type: text/html, Size: 1189 bytes --]
next prev parent reply other threads:[~2016-03-18 3:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 14:07 bug#23038: 25.0.92; M-% from isearch broken (error in isearch--describe-regexp-mode) Michael Heerdegen
2016-03-17 14:25 ` Kaushal Modi
2016-03-18 3:53 ` Artur Malabarba [this message]
2016-03-18 14:58 ` Kaushal Modi
2016-03-18 15:08 ` Michael Heerdegen
2016-03-18 15:14 ` Kaushal Modi
2016-03-18 16:07 ` Stephen Berman
2016-03-18 16:15 ` Kaushal Modi
2016-03-18 16:29 ` Michael Heerdegen
2016-03-18 16:36 ` Michael Heerdegen
2016-03-18 16:39 ` Kaushal Modi
2016-03-18 21:15 ` Stephen Berman
2016-03-18 21:21 ` Michael Heerdegen
2016-03-20 15:38 ` Michael Heerdegen
2016-03-20 15:42 ` Kaushal Modi
2016-03-20 23:47 ` Michael Heerdegen
2016-03-21 0:09 ` Michael Heerdegen
2016-03-21 0:25 ` Kaushal Modi
2016-03-21 0:29 ` Michael Heerdegen
2016-03-21 2:41 ` Kaushal Modi
2016-03-22 0:14 ` Michael Heerdegen
2016-03-22 0:38 ` Kaushal Modi
2016-03-21 10:03 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-K6U5qT0nEiB8HJB3h9KhHEozk5hHXMuftJhgcxJhGWuw@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=23038@debbugs.gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.