Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it?

[Artur Malabarba <bruce.connor.am@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

> > What do you mean by support? Here's what some themes do:
> >
> > ;;;###autoload
> >
> > (and load-file-name (boundp 'custom-theme-load-path) (add-to-list
> > 'custom-theme-load-path (file-name-as-directory (file-name-directory
> > load-file-name))))
> >
> > It might be worth defining a notation of sorts that would have
> > make-autoloads do this for you automatically. But in the mean time,
> > use the snippet above, don't ask people to require your theme.
> >
>
> I had actually tried the aforementioned snippet (placed in
> ahungry-theme.el) in the past, but it never gets evaluated unless I have
> a (require 'ahungry-theme) in the init (which is how I discovered that
> the simple 'require' applies most the theme).

Did you notice that the snippet starts with ";;;###autoload"?
That should take care of adding it to the auto loads file. If it doesn't,
then something is wrong.

>
> Adding the following to ahungry-theme-autoloads.el:
>
> (add-to-list 'custom-theme-load-path (or (file-name-directory #$) (car
> load-path)))

This kind of what the above snippet is supposed to do.

> lets a simple (load-theme 'ahungry) work as expected (prompt to trust
> the theme, and a second to remember the trust choice), as well as
> applying the theme, without requiring user intervention of setting the
> custom-theme-load-path in their init.

Yes.

> Since I have a dependency defined in the theme file of ((emacs "24)),
> which will thus have the load-theme support, it is probably unnecessary
> to have a check for (boundp 'custom-theme-load-path) right?

I believe so.

> If I manually create and add an "ahungry-theme-autoloads.el" file in
> elpa/packages/ahungry-theme, will it supersede the one Elpa creates
> automatically?

Possibly, I'd have to look into the code. But that's the wrong way of doing
things. It's better to just figure out why your file isn't being generated
properly.

[-- Attachment #2: Type: text/html, Size: 2398 bytes --]