From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode? Date: Wed, 6 Jan 2016 11:42:26 -0200 Message-ID: References: <83d1tg57p6.fsf@gnu.org> <87fuybqdby.fsf@gmail.com> <87lh82vq6t.fsf@gmail.com> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0b778c5baf070528aa8608 X-Trace: ger.gmane.org 1452087766 7116 80.91.229.3 (6 Jan 2016 13:42:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2016 13:42:46 +0000 (UTC) Cc: Leo Liu , emacs-devel To: Oleh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 14:42:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGoMP-0002HG-CD for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 14:42:45 +0100 Original-Received: from localhost ([::1]:54272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGoMO-00045C-PP for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 08:42:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGoM9-000457-BM for emacs-devel@gnu.org; Wed, 06 Jan 2016 08:42:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGoM8-0007Ki-7T for emacs-devel@gnu.org; Wed, 06 Jan 2016 08:42:29 -0500 Original-Received: from mail-yk0-x229.google.com ([2607:f8b0:4002:c07::229]:35033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGoM8-0007Ke-2P for emacs-devel@gnu.org; Wed, 06 Jan 2016 08:42:28 -0500 Original-Received: by mail-yk0-x229.google.com with SMTP id x67so315381447ykd.2 for ; Wed, 06 Jan 2016 05:42:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=BINsCiBW0Ed41DsYoxQEufq0z9O/50/mWsEg6E2gPHo=; b=nzz+SGxbg8VvkJzjvxGqHU5PTiq/7FRDrBUSszbq74X9SiXGTR5F5m6bac/myisDLF ZoYfXtBCuNZb+hzUTSyxqYVhSxprvEbb+cnO6mUU+eL1ybI4AzaLu++Wjl2MjryA5ZgL 1Ri5orF9+RL8TZb8NMotAaJKJJJQmFAOok1M0oUBIyE84NbzYACRjVTjzN9/Mb2bi82z bKqqCxbKI4IFB/2HkmQlg6PRRnersJhcksvaxriBzXADzNtwe3z1PwGf85nylvZVtNzU 7H7NL1Z2Hl2mDcRE2U7KOYbDnE2UcPEoyv9tbW2R9pXgxFr9P8kfSm8LZfRg1qGL14pN ZzPA== X-Received: by 10.129.155.79 with SMTP id s76mr71269648ywg.89.1452087747258; Wed, 06 Jan 2016 05:42:27 -0800 (PST) Original-Received: by 10.129.87.130 with HTTP; Wed, 6 Jan 2016 05:42:26 -0800 (PST) Original-Received: by 10.129.87.130 with HTTP; Wed, 6 Jan 2016 05:42:26 -0800 (PST) In-Reply-To: <87lh82vq6t.fsf@gmail.com> X-Google-Sender-Auth: r5ERBW1GVqPT8btLas-bBGiCcMI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197696 Archived-At: --94eb2c0b778c5baf070528aa8608 Content-Type: text/plain; charset=UTF-8 On Jan 6, 2016 10:38 AM, "Oleh Krehel" wrote: > > Leo Liu writes: > > > Secondly those forms already indent correctly without introducing > > (indent 1) > > Not true. Here's the indentation without an indent spec: > > (define-minor-mode ace-window-display-mode > "Minor mode for showing the ace window key in the mode line." > :global t) > > Here's the correct indentation with (indent 1) spec: > > (define-minor-mode ace-window-display-mode > "Minor mode for showing the ace window key in the mode line." > :global t) > > This applies when (setq lisp-indent-function 'common-lisp-indent-function) > is used. What if you set the indent spec to defun? Does that work? --94eb2c0b778c5baf070528aa8608 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Jan 6, 2016 10:38 AM, "Oleh Krehel" <ohwoeowho@gmail.com> wrote:
>
> Leo Liu <sdl.web@gmail.com= > writes:
>
> > Secondly those forms already indent correctly without introducing=
> > (indent 1)
>
> Not true. Here's the indentation without an indent spec:
>
> (define-minor-mode ace-window-display-mode
> =C2=A0 =C2=A0 "Minor mode for showing the ace window key in the m= ode line."
> =C2=A0 :global t)
>
> Here's the correct indentation with (indent 1) spec:
>
> (define-minor-mode ace-window-display-mode
> =C2=A0 "Minor mode for showing the ace window key in the mode lin= e."
> =C2=A0 :global t)
>
> This applies when (setq lisp-indent-function 'common-lisp-indent-f= unction)
> is used.

What if you set the indent spec to defun? Does that work? --94eb2c0b778c5baf070528aa8608--