all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Suspicious code in align.el
@ 2016-01-01 19:47 Artur Malabarba
  2016-01-02 22:18 ` John Wiegley
  0 siblings, 1 reply; 6+ messages in thread
From: Artur Malabarba @ 2016-01-01 19:47 UTC (permalink / raw)
  To: emacs-devel

In line 890 of this file, there's a call to align-regexp that looks like this:

(align-region beg end
              (or exclude-rules
                  align-mode-exclude-rules-list
                  align-exclude-rules-list)
              nil
              separator
              (function
               (lambda (b e mode)
                 (when (and mode (listp mode))
                   (setq sec-first (min sec-first b)
                         sec-last  (max sec-last e))))))

Note how the separator here is passed as 5th argument, while the
docstring of `align-region' documents it as the 3th arg. Furthermore,
the exclude-rules are passed as 3rd arg, but they're documented as
5th.
Is this correct?

Apparently this was written 15 years ago, so this means I'm either
missing something or this code branch is never reached.

Cheers,
Artur



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-01-03 19:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-01 19:47 Suspicious code in align.el Artur Malabarba
2016-01-02 22:18 ` John Wiegley
2016-01-03 15:54   ` Artur Malabarba
2016-01-03 16:40     ` Eli Zaretskii
2016-01-03 19:11       ` Artur Malabarba
2016-01-03 19:55       ` John Wiegley

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.