all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Suspicious code in align.el
Date: Fri, 1 Jan 2016 19:47:34 +0000	[thread overview]
Message-ID: <CAAdUY-K+VCjSdGxAMZ=71saUsVffNJpivc1rPhtEQ6JHk3Ovfw@mail.gmail.com> (raw)

In line 890 of this file, there's a call to align-regexp that looks like this:

(align-region beg end
              (or exclude-rules
                  align-mode-exclude-rules-list
                  align-exclude-rules-list)
              nil
              separator
              (function
               (lambda (b e mode)
                 (when (and mode (listp mode))
                   (setq sec-first (min sec-first b)
                         sec-last  (max sec-last e))))))

Note how the separator here is passed as 5th argument, while the
docstring of `align-region' documents it as the 3th arg. Furthermore,
the exclude-rules are passed as 3rd arg, but they're documented as
5th.
Is this correct?

Apparently this was written 15 years ago, so this means I'm either
missing something or this code branch is never reached.

Cheers,
Artur



             reply	other threads:[~2016-01-01 19:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 19:47 Artur Malabarba [this message]
2016-01-02 22:18 ` Suspicious code in align.el John Wiegley
2016-01-03 15:54   ` Artur Malabarba
2016-01-03 16:40     ` Eli Zaretskii
2016-01-03 19:11       ` Artur Malabarba
2016-01-03 19:55       ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-K+VCjSdGxAMZ=71saUsVffNJpivc1rPhtEQ6JHk3Ovfw@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.