* Re: fix/not-defined-at-runtime ab4df9c: Byte compiler: fix spurious warnings "might not be defined at runtime".
[not found] ` <E1a0DHp-0003DQ-GM@vcs.savannah.gnu.org>
@ 2015-11-22 12:51 ` Artur Malabarba
2015-11-24 10:13 ` [Emacs-diffs] " Alan Mackenzie
0 siblings, 1 reply; 2+ messages in thread
From: Artur Malabarba @ 2015-11-22 12:51 UTC (permalink / raw)
To: emacs-devel, Alan Mackenzie; +Cc: emacs-diffs
> + (let ((byte-compile-unresolved-functions
> + byte-compile-unresolved-functions)
> + (byte-compile-new-defuns
> + byte-compile-new-defuns))
This really needs an explanatory comment. Someone who's reading this
code won't know why these magic variables should have their values
preserved.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] fix/not-defined-at-runtime ab4df9c: Byte compiler: fix spurious warnings "might not be defined at runtime".
2015-11-22 12:51 ` fix/not-defined-at-runtime ab4df9c: Byte compiler: fix spurious warnings "might not be defined at runtime" Artur Malabarba
@ 2015-11-24 10:13 ` Alan Mackenzie
0 siblings, 0 replies; 2+ messages in thread
From: Alan Mackenzie @ 2015-11-24 10:13 UTC (permalink / raw)
To: Artur Malabarba; +Cc: emacs-diffs, emacs-devel
Heillo, Artur.
On Sun, Nov 22, 2015 at 12:51:19PM +0000, Artur Malabarba wrote:
> > + (let ((byte-compile-unresolved-functions
> > + byte-compile-unresolved-functions)
> > + (byte-compile-new-defuns
> > + byte-compile-new-defuns))
> This really needs an explanatory comment. Someone who's reading this
> code won't know why these magic variables should have their values
> preserved.
Thanks. I'll add this comment before merging into emacs-25.
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151121185324.12304.44953@vcs.savannah.gnu.org>
[not found] ` <E1a0DHp-0003DQ-GM@vcs.savannah.gnu.org>
2015-11-22 12:51 ` fix/not-defined-at-runtime ab4df9c: Byte compiler: fix spurious warnings "might not be defined at runtime" Artur Malabarba
2015-11-24 10:13 ` [Emacs-diffs] " Alan Mackenzie
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.