From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: builds are getting slower? Date: Tue, 26 Jan 2016 20:15:21 +0000 Message-ID: References: <8337vab7nx.fsf@gnu.org> <0d7fkmdxj1.fsf@fencepost.gnu.org> <566D0BEB.4010707@cs.ucla.edu> <52wpsif21j.fsf@fencepost.gnu.org> <6tpoy9aorv.fsf@fencepost.gnu.org> <83fuz54sfk.fsf@gnu.org> <83d1u73cz8.fsf@gnu.org> <83lh8u1u71.fsf@gnu.org> <87k2n9rjib.fsf@gmail.com> <87y4blru90.fsf@gmail.com> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1453839368 12254 80.91.229.3 (26 Jan 2016 20:16:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jan 2016 20:16:08 +0000 (UTC) Cc: Eli Zaretskii , Paul Eggert , emacs-devel To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 26 21:16:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOA21-0005Xr-QU for ged-emacs-devel@m.gmane.org; Tue, 26 Jan 2016 21:16:05 +0100 Original-Received: from localhost ([::1]:46527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA21-00028K-60 for ged-emacs-devel@m.gmane.org; Tue, 26 Jan 2016 15:16:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA1l-000280-2T for emacs-devel@gnu.org; Tue, 26 Jan 2016 15:15:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOA1h-0007Vz-3w for emacs-devel@gnu.org; Tue, 26 Jan 2016 15:15:48 -0500 Original-Received: from mail-yk0-x230.google.com ([2607:f8b0:4002:c07::230]:35035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA1d-0007VA-VT; Tue, 26 Jan 2016 15:15:42 -0500 Original-Received: by mail-yk0-x230.google.com with SMTP id u68so85762785ykd.2; Tue, 26 Jan 2016 12:15:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=O1LvaJotwY4kJiblidNlCnRr+pmoS0mgmIgz13X0Das=; b=kzlI4Dk7s0dQyDG/MC1EUWFjntM2VeL9yW2ra05lzRL+SFnCJLFHJ3QqjU8kfpF8x/ AKqhYVpFDlvoB8OzZXdt8iKXVpv4bgZSua6Ctyx8GJL+ZnHJxSGMI4PXsG+7oKMp+Ke3 XFs3c1vkOOK40K00u5BbUgEZwPQJzulvG4iBq8OfWcMIhpGEEzcrKD0Hx39P2pJflPQy 3Makh0aYMb9MIfUo0exWdBHtxAsorfE9uer75bJYp69L8DCInMbbSs/tRbmt5EZYEth4 4LXX0WIosBlNPYrOwJoUi3Yk4SGbpmLiwNM3nCv2ggeVNsD6tQMsMwdTLghMhcoi/3It G2Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:sender:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=O1LvaJotwY4kJiblidNlCnRr+pmoS0mgmIgz13X0Das=; b=HGd+vPlohrwjZs49K20kKzeRIZAqvuTUhTuBUD0nF1enkedX+e8JRGU2cTt6FdIFvM sHGfqT4E5jGRc+u3OeDQ+iSqlonujZ3RlqKad6C8RSxtK1KsZoidEeHTyWxqOqyzTKQH laY4/Cg2v1bFsjkekDIJjiAz87C7fycxwIetqZW+sumC4NNJvcUXjyaqNz0Q3H9iIEE3 TG7nQoSWcDUz+hZLr5lFvPXAw1CKV6XDJbuyCzAPBW9/6Dc6F3hbrMJrpgRZn9yKePTe rwM2SH3BsCOV56JWAIBKDaAoYkG0CvEJNPX2S+5k6GA2o+9AXVCn3qjeXSdfI3fELjcT aYSA== X-Gm-Message-State: AG10YOTTa6JsJwxptjKPY76HZdcpA/e1oGAByDRUQOjvbW36/pDOoar+/jvPRHeG+V8qsBP+Jd6Wp9btRnmAEg== X-Received: by 10.129.114.194 with SMTP id n185mr12286906ywc.283.1453839341503; Tue, 26 Jan 2016 12:15:41 -0800 (PST) Original-Received: by 10.129.119.10 with HTTP; Tue, 26 Jan 2016 12:15:21 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: HEQx0wpDvxG7aT_cFaGTAiGqoGk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c07::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198880 Archived-At: On 26 January 2016 at 18:52, Glenn Morris wrote: > Artur Malabarba wrote: > >>> Then I guess I'll change it to use a fixed filename, probably >>> .dir-locals-2.el' or.dir-locals-user.el'. >> >> Done. > > I'm afraid this has made no difference to the times I measure. > I checked that if I apply a diff to revert back to a single dir-locals > file, the times do indeed fall back to what they were originally. I'm very surprised at this. The emacs sources don't even have a .dir-locals-2.el. So we're not visiting an extra file or reading extra lisp, we're just checking for the existence of this file (exactly once for each time we would check the existence of .dir-locals.el anyway). Maybe the slowness is not really where I expected (filesystem interaction), but is perhaps somewhere else. > If no-one else other than me notices this, perhaps you should forget > about it. (Again, these are the times for non-parallel debug bootstrap > builds.) I don't notice it because I build infrequently and never pay attention while building, so I really don't count. > As a final comment, if the aim is just to override an existing > dir-locals files without modifying it, this can be done by direct > application of dir-locals-set-class-variables and > dir-locals-set-directory-class. The issue there is that the UI isn't as > convenient, and it completely replaces any dir-locals file rather than > appending+overriding it. But those things could presumably be improved. I can revert this feature if people prefer. But I quite like the convenience (and ease-of-use) of writing a second .dir-locals, and the merge (appending+overriding) helps as well. We can also just revert it from the release branch for the moment, and postpone it until emacs 26 while we settle on a preferred interface/implementation.