From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/package-fix e5d5cdf 1/2: emacs-lisp/package.el: Indicate incompatible packages. Date: Sat, 14 Feb 2015 18:04:07 +0000 Message-ID: References: <20150211170820.10979.16862@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b3a85e6ecffb2050f102dc0 X-Trace: ger.gmane.org 1423937060 3308 80.91.229.3 (14 Feb 2015 18:04:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2015 18:04:20 +0000 (UTC) Cc: chad , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 14 19:04:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMh4k-000509-0C for ged-emacs-devel@m.gmane.org; Sat, 14 Feb 2015 19:04:18 +0100 Original-Received: from localhost ([::1]:60783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMh4j-0007Lj-Ar for ged-emacs-devel@m.gmane.org; Sat, 14 Feb 2015 13:04:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMh4f-0007JR-9V for emacs-devel@gnu.org; Sat, 14 Feb 2015 13:04:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMh4a-0004SF-Hv for emacs-devel@gnu.org; Sat, 14 Feb 2015 13:04:13 -0500 Original-Received: from mail-ob0-x234.google.com ([2607:f8b0:4003:c01::234]:62075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMh4a-0004S8-Cx for emacs-devel@gnu.org; Sat, 14 Feb 2015 13:04:08 -0500 Original-Received: by mail-ob0-f180.google.com with SMTP id vb8so30366818obc.11 for ; Sat, 14 Feb 2015 10:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=UM8nFSYrwBYqo8zyjYpXgw3/gOqDwWcLBIqc/bi+Vk8=; b=hzhx6eQaLSZ3EDZaLxMCM3/FNxeJhsL7j7LyjUNVsSLIXyvCtjy05mRfjGLfuI8R0a LyBwacP+EC9isVnyCeDCCiq6HITv2bJMZdcyjpKj4Xii1E/gAz3BmtgJX+8r7IGPleLr +XPTOwGd0SDzH23/x7kMjASf/WzjJg8/kq9XY8PXc0Kdp+mcouOpqJhrQd1axeSuyNcZ WlEXq0WLmMXIDdhRH5F4MnD4I5pmKGEGdIcpDpDr1JwAXPvsqH+Dn4X1hVJE86luFZoa qA4NdxooMwyYRF2dzlw853DsrETZZ9eVdIvbcm56vkeTITrsB1eSPLTcsByeRXHA0bff w9eQ== X-Received: by 10.60.144.73 with SMTP id sk9mr8349567oeb.71.1423937047951; Sat, 14 Feb 2015 10:04:07 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Sat, 14 Feb 2015 10:04:07 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Sat, 14 Feb 2015 10:04:07 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: F0SiCdXiZP3VfSzKWfmZ1AUiAbk X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183070 Archived-At: --047d7b3a85e6ecffb2050f102dc0 Content-Type: text/plain; charset=UTF-8 On 13 Feb 2015 20:18, "Artur Malabarba" wrote: > > > Maybe you're right. Just like installation may fail because > > a dependency is missing. Maybe marking those things as > > uninstallable/incompatible is good, but only if we can explain > > concisely/easily enough to the user why it's uninstallable/incompatible. > > Yes, it would be good to add that to the describe package buffer. package--incompatible-p already returns the reason why the package is incompatible, so it's just a matter of formating and printing. This is now done. --047d7b3a85e6ecffb2050f102dc0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 13 Feb 2015 20:18, "Artur Malabarba" <bruce.connor.am@gmail.com> wr= ote:
>
> > Maybe you're right.=C2=A0 Just like installation may fail bec= ause
> > a dependency is missing.=C2=A0 Maybe marking those things as
> > uninstallable/incompatible is good, but only if we can explain > > concisely/easily enough to the user why it's uninstallable/in= compatible.
>
> Yes, it would be good to add that to the describe package buffer. pack= age--incompatible-p already returns the reason why the package is incompati= ble, so it's just a matter of formating and printing.

This is now done.

--047d7b3a85e6ecffb2050f102dc0--