From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#19390: 25.0.50; `package-activate' is too slow Date: Tue, 16 Dec 2014 11:26:15 -0200 Message-ID: References: <86a92oddfp.fsf@yandex.ru> <86mw6nkc6n.fsf@yandex.ru> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1418736792 12877 80.91.229.3 (16 Dec 2014 13:33:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Dec 2014 13:33:12 +0000 (UTC) Cc: 19390@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 16 14:33:05 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0sFM-0008Pt-O9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Dec 2014 14:33:04 +0100 Original-Received: from localhost ([::1]:44793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0sFK-0007gs-SS for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Dec 2014 08:33:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0s9c-0005ho-KV for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 08:27:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0s9W-0001AS-95 for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 08:27:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0s9W-0001AN-6J for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 08:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y0s9V-0007ou-Lh for bug-gnu-emacs@gnu.org; Tue, 16 Dec 2014 08:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Dec 2014 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19390-submit@debbugs.gnu.org id=B19390.141873637930002 (code B ref 19390); Tue, 16 Dec 2014 13:27:01 +0000 Original-Received: (at 19390) by debbugs.gnu.org; 16 Dec 2014 13:26:19 +0000 Original-Received: from localhost ([127.0.0.1]:47573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0s8o-0007np-QV for submit@debbugs.gnu.org; Tue, 16 Dec 2014 08:26:19 -0500 Original-Received: from mail-ob0-f173.google.com ([209.85.214.173]:56942) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y0s8m-0007ne-68 for 19390@debbugs.gnu.org; Tue, 16 Dec 2014 08:26:16 -0500 Original-Received: by mail-ob0-f173.google.com with SMTP id uy5so22857810obc.4 for <19390@debbugs.gnu.org>; Tue, 16 Dec 2014 05:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=AZ0lJl6w9eGdgqyVsohfsA+NKH9D0f0qg/CPkb/Plxw=; b=Gu6It1zZwwC61qwC1rG4i6kDbn4caSlh2SHZxV3EqW9XFqggW55unChTN36OMIkfkF JuYbszAxmc/HGG/LbqMTP6K76DH5iDGWLN3DPSsLQzYJUszTrgrhcp+Mrg0AcEmpE3qu 1l9YiIrjfpkoAe0ngC+r15py9EkahBvFhODg3IXmbvzrGgeRM3f53YABdkwA38S9yU3+ OQG9EVAK38QxHHJxhr92wMlAAxUarv50r3ZGl2GE40aGPPxsWOghPbOviJLrGa+2xvRd f5fgUx4yMGqCahSWpJjy39O9Oh2AyLo56I+9ms3OcAm8dZxrbZWK7mnqcf5KiCI+riQ2 mwjg== X-Received: by 10.182.58.102 with SMTP id p6mr14057702obq.84.1418736375674; Tue, 16 Dec 2014 05:26:15 -0800 (PST) Original-Received: by 10.76.154.106 with HTTP; Tue, 16 Dec 2014 05:26:15 -0800 (PST) In-Reply-To: <86mw6nkc6n.fsf@yandex.ru> X-Google-Sender-Auth: g4v1-ci7_6ryH4o0P7ghfT6fViE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97379 Archived-At: I didn't notice anything as aggravating as the report, but I agree my latest patch is a performance concern. The proposed patch looks good, just a couple of notes: 1. I'd use RELOAD for the name of the optional argument. 2. Since this function now takes a second (somewhat non-trivial argument), we should add a docstring to it: "Activate package given by PKG-DESC, even if it was already active. If RELOAD is non-nil, also `load' any files inside the package which correspond to previously loaded files (those returned by `package--list-loaded-files'). This is called internally by `package-activate'."