Re: [ELPA] New package: arbitools

[Artur Malabarba <bruce.connor.am@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

WRT to identation conventions, it should be enough to just select the whole
buffer and hit TAB (or M-x indent-region).

In any case, thanks for the addition, David. :-)

Artur

On 22 February 2016 at 07:01, David Gonzalez <mr_rookes@yahoo.com> wrote:

> Ok. Thanks.
> I'll do more research on indentation conventions.
>
> ------------------------------
> *From:* Jonas Bernoulli <jonas@bernoul.li>
> *To:* David Gonzalez <mr_rookes@yahoo.com>
> *Cc:* "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> *Sent:* Sunday, February 21, 2016 7:58 PM
> *Subject:* Re: [ELPA] New package: arbitools
>
> The library provides the wrong feature (`arbitools-mode').  It should
> instead provide the feature which matches the filename (but of course
> without the ".el" suffix): `arbitools'.
>
> Also there is a space missing in ";;;Commentary:".
>
> And you might want to consider not putting closing parens in the wrong
> place.  You should fix that at least for the definition of
> `arbitools-mode'.
>
> For data, like the value of `arbitools-highlights', which is likely to
> be extended in the future it is okay to put closing parens on a separte
> line.  But you should put both closing parents on the same line and
> indent that line correctly.  Actually you should reindent the complete
> value.  But first you need to correctly comment the commented lines,
> replacing ";(" with ";; (" (also in other definitions).  Then mark the
> `defvar' and use `M-x indent-region RET'.
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 3350 bytes --]