From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Adding to ELPA? Date: Sat, 10 Oct 2015 08:08:25 +0100 Message-ID: References: <87si5k3vtt.fsf@fencepost.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c3f5c42f2ec90521bac316 X-Trace: ger.gmane.org 1444460928 27473 80.91.229.3 (10 Oct 2015 07:08:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Oct 2015 07:08:48 +0000 (UTC) Cc: emacs-devel To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 10 09:08:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZkoGs-000832-Ks for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 09:08:46 +0200 Original-Received: from localhost ([::1]:43885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkoGs-0006SN-6b for ged-emacs-devel@m.gmane.org; Sat, 10 Oct 2015 03:08:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkoGb-0006SG-BM for emacs-devel@gnu.org; Sat, 10 Oct 2015 03:08:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkoGa-0006gq-Bl for emacs-devel@gnu.org; Sat, 10 Oct 2015 03:08:29 -0400 Original-Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:35029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkoGY-0006gN-Ix; Sat, 10 Oct 2015 03:08:26 -0400 Original-Received: by lbwr8 with SMTP id r8so100562918lbw.2; Sat, 10 Oct 2015 00:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=YCFUhYYz7fpmeHP3E1x1GxkJfcQ4RI6zbifjtH9u32c=; b=nEqqKXVxT8K8eaiyJWEvLQoc42u0dcvxZo1/yjCtu4WHWqEaaHJi+eRpA8Dd1Cm1oO PMiyLIJ+J8kMDDnHNYHger102vfRfVWOgfl9NymQQzs1L1ifGmNYhPxORN3HyuRnRR7T Sc8vkyzGSnvyP95LqER3HGr8TPRylDcms8BFzmnKj0Sblh+gudNwNcOVdUI7ivzfMDB+ 8rHrmUCfKNXGYxTrEQ1x9s5To85E/X5BPYBh9XHnWbWW48GpUnSTcMIN7M1qw5mRLy+u OkKJNfLeg3yavY7lX3IcvyOcqiPInE6MVjPdukbVkYTEqN7u1Hl3Wy6N2aHr+E9Wy1OH Mqwg== X-Received: by 10.112.54.169 with SMTP id k9mr8113605lbp.95.1444460905834; Sat, 10 Oct 2015 00:08:25 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Sat, 10 Oct 2015 00:08:25 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Sat, 10 Oct 2015 00:08:25 -0700 (PDT) In-Reply-To: <87si5k3vtt.fsf@fencepost.gnu.org> X-Google-Sender-Auth: c735RmyXkWubNJBO3-q0JyiD_Ac X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191090 Archived-At: --001a11c3f5c42f2ec90521bac316 Content-Type: text/plain; charset=UTF-8 On 9 Oct 2015 4:28 pm, "David Kastrup" wrote: > > > Unfortunately, the list server seems to be really, really, slow right > now. At any rate, would it be the correct way of proceeding to just > push the following commit to ELPA? Just like that? If you've done it before, then yes, pretty much. If you haven't, showing the patch here (like you just did) is a good idea to make sure you're doing it right. You can also bring it here if you're unsure whether it's GElpa material (whatever that means). Maybe we should request that people always mention it here before uploading new packages, just to make sure it's not replicating an existing one. As for your code, I noticed two things. 1. See other packages for the copyright line used. 2. You need to depend on cl-lib 0.5 and require it (probably at compile time). --001a11c3f5c42f2ec90521bac316 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 9 Oct 2015 4:28 pm, "David Kastrup" <dak@gnu.org> wrote:
>
>
> Unfortunately, the list server seems to be really, really, slow right<= br> > now.=C2=A0 At any rate, would it be the correct way of proceeding to j= ust
> push the following commit to ELPA?=C2=A0 Just like that?

If you've done it before, then yes, pretty much.
If you haven't, showing the patch here (like you just did) is a good id= ea to make sure you're doing it right.

You can also bring it here if you're unsure whether it&#= 39;s GElpa material (whatever that means). Maybe we should request that peo= ple always mention it here before uploading new packages, just to make sure= it's not replicating an existing one.

As for your code, I noticed two things.
1. See other packages for the copyright line used.
2. You need to depend on cl-lib 0.5 and require it (probably at compile tim= e).

--001a11c3f5c42f2ec90521bac316--