From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 5640cd0 04/12: el-search: some comment changes Date: Mon, 12 Oct 2015 00:29:57 +0100 Message-ID: References: <20151011103325.2269.2052@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c237f03b62820521dc9730 X-Trace: ger.gmane.org 1444606223 8326 80.91.229.3 (11 Oct 2015 23:30:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Oct 2015 23:30:23 +0000 (UTC) Cc: emacs-elpa-diffs@gnu.org To: Michael Heerdegen , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 12 01:30:18 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZlQ4H-0004vc-9M for ged-emacs-devel@m.gmane.org; Mon, 12 Oct 2015 01:30:17 +0200 Original-Received: from localhost ([::1]:50185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlQ4G-0003qo-2g for ged-emacs-devel@m.gmane.org; Sun, 11 Oct 2015 19:30:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlQ40-0003pX-Q6 for emacs-devel@gnu.org; Sun, 11 Oct 2015 19:30:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlQ3z-0007Yx-Tv for emacs-devel@gnu.org; Sun, 11 Oct 2015 19:30:00 -0400 Original-Received: from mail-lb0-x229.google.com ([2a00:1450:4010:c04::229]:35630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlQ3x-0007YM-TR; Sun, 11 Oct 2015 19:29:58 -0400 Original-Received: by lbwr8 with SMTP id r8so125828562lbw.2; Sun, 11 Oct 2015 16:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=Dj34xR6ofT3IqR9q1bN4bPnWMymSAHeXRTLuC2EUGyc=; b=D8fDDYBUouGq5MXj08+Mba8s6EB6tWI0MSH5GeIVCjrOCIDqq2bioZqxGqQtmu9zEH 2TlZD+K0mkzoyfRkj0944BuZsDHkDCruEDLRZDKZWVmA2f3w0z3BKR6NUXCyATBZK99F NszK0XgvrmtwyvV1xgI83TsZuoHu7eUcFX2ZvZW0nfT1Wt8iIWjgCYzE0jGXfLJVY8Iy 9lWN8OMJgIyP0XDoZO/e7D6ctj7waru9hnU6l4G8HZqI5oLh1bDZOb/h2W39HdWaHDWi lNOxHPhgT3Llw5rbWFDOjzJfEDzlBC6QE4uOSn5qBmzwSWXRA8rQrMV5VD7V6j9q0HWL oV5A== X-Received: by 10.112.168.228 with SMTP id zz4mr11295913lbb.73.1444606197324; Sun, 11 Oct 2015 16:29:57 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Sun, 11 Oct 2015 16:29:57 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Sun, 11 Oct 2015 16:29:57 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: rfhu_EhgM-AbrEaana-EBkqzl4k X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191294 Archived-At: --001a11c237f03b62820521dc9730 Content-Type: text/plain; charset=UTF-8 On 11 Oct 2015 11:33 am, "Michael Heerdegen" wrote: > + ;; FIXME: an interesting alternative would be to really integrate it > + ;; with Isearch, using `isearch-search-fun-function'. > + ;; Alas, this is not trivial if we want to transfer our optimizations. > (interactive) > (el-search-pattern > (el-search--read-pattern Can you explain why? I've been thinking of making some refactorings to isearch (after the feature freeze) and I could try to extend isearch-search-fun-function to cover your use case if it's not too hard. Best, Artur --001a11c237f03b62820521dc9730 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 11 Oct 2015 11:33 am, "Michael Heerdegen" <michael_heerdegen@web.de> wrote:
> +=C2=A0 ;; FIXME: an interesting alternative would be to really integr= ate it
> +=C2=A0 ;; with Isearch, using `isearch-search-fun-function'.
> +=C2=A0 ;; Alas, this is not trivial if we want to transfer our optimi= zations.
> =C2=A0 =C2=A0(interactive)
> =C2=A0 =C2=A0(el-search-pattern
> =C2=A0 =C2=A0 (el-search--read-pattern

Can you explain why? I've been thinking of making some r= efactorings to isearch (after the feature freeze) and I could try to extend= isearch-search-fun-function to cover your use case if it's not too har= d.

Best,
Artur

--001a11c237f03b62820521dc9730--