From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Mon, 14 Dec 2015 01:19:51 +0000 Message-ID: References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> <83lh916jpp.fsf@gnu.org> <871tasbnhh.fsf@mail.linkov.net> <83d1uc6sdq.fsf@gnu.org> <874mfntfgq.fsf@mail.linkov.net> <8737v5ubog.fsf@mail.linkov.net> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1140118e4ac4fc0526d17841 X-Trace: ger.gmane.org 1450056012 19030 80.91.229.3 (14 Dec 2015 01:20:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Dec 2015 01:20:12 +0000 (UTC) Cc: Alan Mackenzie , Eli Zaretskii , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 14 02:20:11 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8HoA-00033h-Ax for ged-emacs-devel@m.gmane.org; Mon, 14 Dec 2015 02:20:10 +0100 Original-Received: from localhost ([::1]:57258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Ho9-00061f-A6 for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 20:20:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Hnv-00061P-IU for emacs-devel@gnu.org; Sun, 13 Dec 2015 20:19:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8Hnu-0000Eb-Kq for emacs-devel@gnu.org; Sun, 13 Dec 2015 20:19:55 -0500 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:32815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8Hns-0000Dv-OL; Sun, 13 Dec 2015 20:19:52 -0500 Original-Received: by lfap203 with SMTP id p203so42094565lfa.0; Sun, 13 Dec 2015 17:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ZyVdyvTSQZ3x9Iq1l1DzAcXjRDePaj/AZD2bg/Y9S0Y=; b=qeDUoRk//MD3JbgIQmzudj2BzN0A8twCCasgsjgCqoYpiOQkUaDuXOzPsBVw3mB37I d4SRRsBHjafWbG46jxPZldw418sOlJcx0a+6IyXRspHbnDmqIf2155mCr35jWZvtiaVj 2RLQQSqkMQrnrBmbHaNmedNaKd1Zdb8n1Ju0Qreulwo6oa1gIP6DeZHQ8hACDWXA8Q1v VQCG5ziFvIOFNr0Px7D7KqT37YCMFFc6TM64FNOdBBzKoDjWFb41dXvK0lnFOY/hgb/Q Ff4c8prs37wqSqsvmTWlz4CZOyVKrFQ++ewKHe0Kxvy8FJgItFrhEEGiElYVoIlBhL6p A/CA== X-Received: by 10.25.208.206 with SMTP id h197mr12171750lfg.153.1450055991736; Sun, 13 Dec 2015 17:19:51 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Sun, 13 Dec 2015 17:19:51 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Sun, 13 Dec 2015 17:19:51 -0800 (PST) In-Reply-To: <8737v5ubog.fsf@mail.linkov.net> X-Google-Sender-Auth: Q8ZTFwvSWrSwYb1WP0UqoEOsbic X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196230 Archived-At: --001a1140118e4ac4fc0526d17841 Content-Type: text/plain; charset=UTF-8 On 14 Dec 2015 12:16 am, "Juri Linkov" wrote: > Ohh, and I'd add also search-default-regexp-mode -> search-default-regexp-function > that currently causes confusion due to its similarity with isearch-regexp-function. The thing is that this variable is not necessarily a function, it can be nil or t too. I'd rather reserve the suffix "-function" for variables that necessarily hold a function. > > I don't see what these have to do with the readability of isearch el, but > > by all means, feel free to do these. > > Maybe better to wait for establishing of regular merges from emacs-25 to > master, because I'm afraid that renaming character-fold.el to char-fold.el > now might cause merge conflicts on the first such merge. As long as no changes have been made to this file on the master branch, there shouldn't be any conflict. But it's probably best to wait. --001a1140118e4ac4fc0526d17841 Content-Type: text/html; charset=UTF-8

On 14 Dec 2015 12:16 am, "Juri Linkov" <juri@linkov.net> wrote:
> Ohh, and I'd add also search-default-regexp-mode -> search-default-regexp-function
> that currently causes confusion due to its similarity with isearch-regexp-function.

The thing is that this variable is not necessarily a function, it can be nil or t too. I'd rather reserve the suffix "-function" for variables that necessarily hold a function.

> > I don't see what these have to do with the readability of isearch el, but
> > by all means, feel free to do these.
>
> Maybe better to wait for establishing of regular merges from emacs-25 to
> master, because I'm afraid that renaming character-fold.el to char-fold.el
> now might cause merge conflicts on the first such merge.

As long as no changes have been made to this file on the master branch, there shouldn't be any conflict. But it's probably best to wait.

--001a1140118e4ac4fc0526d17841--