From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Should we have a commit size guideline? Date: Wed, 16 Dec 2015 11:12:40 +0000 Message-ID: References: <87zixb6b9f.fsf@fencepost.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1140175204ca0a052701fcf4 X-Trace: ger.gmane.org 1450264381 6380 80.91.229.3 (16 Dec 2015 11:13:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Dec 2015 11:13:01 +0000 (UTC) Cc: emacs-devel To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 16 12:12:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a9A0s-0006ei-Iz for ged-emacs-devel@m.gmane.org; Wed, 16 Dec 2015 12:12:54 +0100 Original-Received: from localhost ([::1]:46607 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9A0m-00080m-SD for ged-emacs-devel@m.gmane.org; Wed, 16 Dec 2015 06:12:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9A0i-00080U-2b for emacs-devel@gnu.org; Wed, 16 Dec 2015 06:12:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9A0h-0007JR-2P for emacs-devel@gnu.org; Wed, 16 Dec 2015 06:12:44 -0500 Original-Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:34449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9A0f-0007JE-4x; Wed, 16 Dec 2015 06:12:41 -0500 Original-Received: by mail-lf0-x22e.google.com with SMTP id y184so26665779lfc.1; Wed, 16 Dec 2015 03:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=F0+3uCkjx7GUI2H7VJLRRO+bh54Udz7mGdQwb0dFZoU=; b=g/B54iCNuMsjcJAnruxzVRDavN4DF6o3ju0Sy4J7cPOakfe5ySazHsMMJaC91//L0F rcaFhu0wOowDtSFHjdtv7A46r9SifXR16VxlJ56oo8B2wnQKp/sEbSKgYEFwTxYYlMkW Xii/bkFG1fAO6kcUiO86mzkSQV0358D/BlnwgvxmYlWkD8/Up1vJnVPNxkMe9Vcm3Ykx Uq9LRBZckRLeKUAXEj7mG6bju/IPuWz0RdDOdkYObOWxA4ycVJ6Xk3sEH15zDT4LBO20 lgjy3EZTsBh4IzcI2iwuXehtp4ztCTV5MZTs3gJdkC8Eww36FLEfP351ryh2CPExaEoT QqWQ== X-Received: by 10.25.147.84 with SMTP id v81mr18210242lfd.119.1450264360172; Wed, 16 Dec 2015 03:12:40 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Wed, 16 Dec 2015 03:12:40 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Wed, 16 Dec 2015 03:12:40 -0800 (PST) In-Reply-To: <87zixb6b9f.fsf@fencepost.gnu.org> X-Google-Sender-Auth: AV-PUkYljWugbQuGlbik4ICFXTU X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196362 Archived-At: --001a1140175204ca0a052701fcf4 Content-Type: text/plain; charset=UTF-8 On 15 Dec 2015 2:23 pm, "David Kastrup" wrote: > > Sure. > > But that commit is not in that class. > > -(defconst dir-locals-file ".dir-locals.el" > +(defconst dir-locals-file ".dir-locals*.el" I considered this part of the same feature. But I agree it could have been made on a follow up commit. > - (message ".dir-locals error: %s" (error-message-string err)) > + (message "%s error: %s" dir-locals-file (error-message-string err)) > > is a bug fix that is independent from the implementation. True! > (when (and (string-prefix-p (car elt) file > - (memq system-type > - '(windows-nt cygwin ms-dos))) > - (> (length (car elt)) (length (car dir-elt)))) > - (setq dir-elt elt))) > + (memq system-type > + '(windows-nt cygwin ms-dos))) > + (> (length (car elt)) (length (car dir-elt)))) > + (setq dir-elt elt))) > (if (and dir-elt > > is a gratuitous spacing change. Oops! > So is most of > > (if (and dir-elt > - (or (null locals-file) > - (<= (length (file-name-directory locals-file)) > - (length (car dir-elt))))) Hm, I see what you mean. I generally trust emacs to not change tabs-to-spaces in lines I didn't touch. Maybe the indentation there was actually wrong (I'm reading this on a variable space font, so I can't tell), or maybe I changed something that changed the indentation and then changed it back again. Anyway, I usually lookout for this before pushing, but in this case the indentation changes are quite mixed with code changes so it probably escaped me. Sorry about that. --001a1140175204ca0a052701fcf4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 15 Dec 2015 2:23 pm, "David Kastrup" <dak@gnu.org> wrote:
>
> Sure.
>
> But that commit is not in that class.
>
> -(defconst dir-locals-file ".dir-locals.el"
> +(defconst dir-locals-file ".dir-locals*.el"

I considered this part of the same feature. But I agree it c= ould have been made on a follow up commit.

> -=C2=A0 =C2=A0 =C2=A0 =C2=A0(message ".dir-locals = error: %s" (error-message-string err))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(message "%s error: %s" dir-loca= ls-file (error-message-string err))
>
> is a bug fix that is independent from the implementation.

True!

> =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (and (string-prefix-p = (car elt) file
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(memq system-type
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'= (windows-nt cygwin ms-dos)))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (> (length= (car elt)) (length (car dir-elt))))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq dir-elt elt)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (memq system-type
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= ;(windows-nt cygwin ms-dos)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(> (= length (car elt)) (length (car dir-elt))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq dir-elt elt)))
> =C2=A0 =C2=A0 =C2=A0(if (and dir-elt
>
> is a gratuitous spacing change.=C2=A0

Oops!

> So is most of
>
> =C2=A0 =C2=A0 =C2=A0(if (and dir-elt
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (or (null locals-file)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (<=3D (len= gth (file-name-directory locals-file))
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (length (car dir-elt)))))

Hm, I see what you mean. I generally trust emacs to not chan= ge tabs-to-spaces in lines I didn't touch. Maybe the indentation there = was actually wrong (I'm reading this on a variable space font, so I can= 't tell), or maybe I changed something that changed the indentation and= then changed it back again.

Anyway, I usually lookout for this before pushing, but in th= is case the indentation changes are quite mixed with code changes so it pro= bably escaped me. Sorry about that.

--001a1140175204ca0a052701fcf4--