From: Artur Malabarba <bruce.connor.am@gmail.com>
To: David Kastrup <dak@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Should we have a commit size guideline?
Date: Wed, 16 Dec 2015 11:12:40 +0000 [thread overview]
Message-ID: <CAAdUY-J9Xk0rbBZFOwzsQJzSRwjZSEafkW-XdB0SLTvebPYzSw@mail.gmail.com> (raw)
In-Reply-To: <87zixb6b9f.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]
On 15 Dec 2015 2:23 pm, "David Kastrup" <dak@gnu.org> wrote:
>
> Sure.
>
> But that commit is not in that class.
>
> -(defconst dir-locals-file ".dir-locals.el"
> +(defconst dir-locals-file ".dir-locals*.el"
I considered this part of the same feature. But I agree it could have been
made on a follow up commit.
> - (message ".dir-locals error: %s" (error-message-string err))
> + (message "%s error: %s" dir-locals-file (error-message-string
err))
>
> is a bug fix that is independent from the implementation.
True!
> (when (and (string-prefix-p (car elt) file
> - (memq system-type
> - '(windows-nt cygwin ms-dos)))
> - (> (length (car elt)) (length (car dir-elt))))
> - (setq dir-elt elt)))
> + (memq system-type
> + '(windows-nt cygwin ms-dos)))
> + (> (length (car elt)) (length (car dir-elt))))
> + (setq dir-elt elt)))
> (if (and dir-elt
>
> is a gratuitous spacing change.
Oops!
> So is most of
>
> (if (and dir-elt
> - (or (null locals-file)
> - (<= (length (file-name-directory locals-file))
> - (length (car dir-elt)))))
Hm, I see what you mean. I generally trust emacs to not change
tabs-to-spaces in lines I didn't touch. Maybe the indentation there was
actually wrong (I'm reading this on a variable space font, so I can't
tell), or maybe I changed something that changed the indentation and then
changed it back again.
Anyway, I usually lookout for this before pushing, but in this case the
indentation changes are quite mixed with code changes so it probably
escaped me. Sorry about that.
[-- Attachment #2: Type: text/html, Size: 2406 bytes --]
next prev parent reply other threads:[~2015-12-16 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 13:48 Should we have a commit size guideline? (was: builds are getting slower?) Artur Malabarba
2015-12-15 14:23 ` Should we have a commit size guideline? David Kastrup
2015-12-16 11:12 ` Artur Malabarba [this message]
2015-12-15 16:16 ` Should we have a commit size guideline? (was: builds are getting slower?) Eli Zaretskii
2015-12-15 17:56 ` Should we have a commit size guideline? John Wiegley
2015-12-16 0:13 ` Paul Eggert
2015-12-16 0:23 ` Dmitry Gutov
2015-12-16 1:00 ` Paul Eggert
2015-12-16 1:19 ` indent-tabs-mode setting in Emacs's dir-locals.el Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-J9Xk0rbBZFOwzsQJzSRwjZSEafkW-XdB0SLTvebPYzSw@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.