From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: package.el dependencies Date: Mon, 2 Feb 2015 12:56:38 -0200 Message-ID: References: <87wq4dpqib.fsf@gmail.com> <87wq44su8v.fsf@gmail.com> <877fw3789y.fsf@gmail.com> <874mr4sbfa.fsf@gmail.com> <87386os8mq.fsf@gmail.com> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1422889027 25368 80.91.229.3 (2 Feb 2015 14:57:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2015 14:57:07 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 02 15:57:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIIQz-00055J-Ga for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 15:57:05 +0100 Original-Received: from localhost ([::1]:55045 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIIQy-0002Z0-Ft for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 09:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIIQa-0002Vn-7O for emacs-devel@gnu.org; Mon, 02 Feb 2015 09:56:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIIQZ-0001RC-8v for emacs-devel@gnu.org; Mon, 02 Feb 2015 09:56:40 -0500 Original-Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:64918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIIQZ-0001R2-4S for emacs-devel@gnu.org; Mon, 02 Feb 2015 09:56:39 -0500 Original-Received: by mail-ob0-f169.google.com with SMTP id wp4so2856513obc.0 for ; Mon, 02 Feb 2015 06:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=H8xc0WAsnxrKAifBCpdZWq+GDCyXLiA/U5EhbSgV9Vo=; b=wxoexhHCXU55Q4WIuF5mhlDRQRBpKOUwSawtw3hKUT4wHm3c9uAGJWORfG4xhxzKf/ HLqhwq9aX3piBdmj+h/f//y5icbqtWQbQuOt7O8/1r8pdypUnkOr4dIxX/0VzTIkBTwB z0B8GgRI/64BFxvVOzducaziJnTWVJHqNHopP3Zb4Qfj1ldmz5APvfmwM62Nj5K/9QT/ R6j8jnFaMlUV/uOxQuL6EPS1RFg25vm7/VygMDqBqjK4K6og+XD9ls7no0uoynX4FV9f 1JmUPGbZrnWiN3LPx+HtljY/ITkS/osGGbC9K04NAvOLY7JwkW2YRViM41KJIXOWeHX/ dn/A== X-Received: by 10.60.54.199 with SMTP id l7mr12273267oep.37.1422888998568; Mon, 02 Feb 2015 06:56:38 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Mon, 2 Feb 2015 06:56:38 -0800 (PST) In-Reply-To: <87386os8mq.fsf@gmail.com> X-Google-Sender-Auth: 1e0PkhPDaAgnm8cxum3EOJs-mlE X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182256 Archived-At: >> We have now duplicates with package--get-deps: >> >> (package--get-deps 'jedi) >> =>(epc auto-complete python-environment epc auto-complete >> python-environment >> concurrent ctable concurrent ctable deferred deferred >> popup popup deferred deferred) >> >> As a workaround, you can use delete-dups, but this need to be >> implemented differently IMO. > > Maybe like this: > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 9a29d63..2157174 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1428,9 +1428,8 @@ The file can either be a tar file or an Emacs Lisp file." > when (assq name package-alist) > collect name)) > (indirect-deps (unless (eq only 'direct) > - (apply #'append > - direct-deps Yes, I made a mistake by adding the `direct-deps' here. I'll remove it. > - (mapcar #'package--get-deps direct-deps))))) > + (cl-loop for p in direct-deps > + append (package--get-deps p 'direct))))) > (cl-case only > (direct direct-deps) > (separate (list direct-deps indirect-deps)) > > (package--get-deps 'jedi) > => (epc auto-complete python-environment concurrent ctable popup deferred) It may have solved this particular example, but if two direct dependencies share the same (indirect) dependency then this will still lead to duplicates. We could try writting an efficient way of avoiding this duplicates, but I'm fine with just using `delete-dups'. And one more thing. Why did you use `(package--get-deps p 'direct)' in this snippet? Passing the `direct' argument will cause it to only return 2nd level dependencies at most (direct dependencies of the direct dependencies). I think it should be just `(package--get-deps p)', shouldn't it? This way it'll keep searching untill the bottom of the dependency tree.