all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21747@debbugs.gnu.org
Subject: bug#21747: 25.0.50; while-no-input breaks kbd event handling when called from post-command-hook
Date: Mon, 26 Oct 2015 00:27:22 +0000	[thread overview]
Message-ID: <CAAdUY-J3rkqvvGJw5qrAM0rTnpjV4C94dqUYEDoxSLUZisR9-Q@mail.gmail.com> (raw)
In-Reply-To: <83lhaqdbq8.fsf@gnu.org>

2015-10-25 18:50 GMT+00:00 Eli Zaretskii <eliz@gnu.org>:
>> Date: Sun, 25 Oct 2015 14:43:06 +0000
>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>> Cc: Tassilo Horn <tsdh@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>, Kim Storm <storm@cua.dk>,
>>       21747@debbugs.gnu.org
>>
>> I've extended the docstring.
>
> Thanks.
>
>> +otherwise the error might happen repeatedly and make Emacs nonfunctional.
>> +
>> +It is usually a bad idea to use this hook for expensive processing.
>> +If unavoidable, `while-no-input' can be used avoid making Emacs
>                                               ^^^
> "to" is missing where indicated.
>
>> +unresponsive while the user types.  Furthermore, this hook is run
>> +before redisplay, so the effect of the executed command won't be
>> +displayed on the buffer until after the hook has finished (giving the
>> +impression that Emacs is hanging).  You can call `redisplay' inside
>> +`while-no-input' to avoid this.
>
> Perhaps only the 1st sentence or 2 sentences should be left in the doc
> string, and the rest moved to the ELisp manual?  It seems too long and
> detailed for a doc string.

How about reducing the second paragraph to this? Still to long?

It is a bad idea to use this hook for expensive processing.  If
unavoidable, wrap your code in `(while-no-input (redisplay) CODE)' to
avoid making Emacs unresponsive while the user types.





  reply	other threads:[~2015-10-26  0:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24  7:42 bug#21747: 25.0.50; while-no-input breaks kbd event handling when called from post-command-hook Tassilo Horn
2015-10-24  8:02 ` Eli Zaretskii
2015-10-24  8:53   ` Tassilo Horn
2015-10-24  9:14     ` Eli Zaretskii
2015-10-24  9:49       ` Tassilo Horn
2015-10-24 10:30         ` Artur Malabarba
2015-10-24 10:52           ` Eli Zaretskii
2015-10-24 12:13             ` Tassilo Horn
2015-10-24 12:45               ` Eli Zaretskii
2015-10-24 13:30                 ` Tassilo Horn
2015-10-24 13:57                   ` Artur Malabarba
2015-10-24 14:06                     ` Eli Zaretskii
2015-10-24 14:05                   ` Eli Zaretskii
2015-10-25  7:19                     ` Tassilo Horn
2015-10-25  8:10                       ` Tassilo Horn
2015-10-25  9:25                         ` Tassilo Horn
2015-10-25 18:45                           ` Eli Zaretskii
2015-10-25 18:49                             ` Tassilo Horn
2015-10-25 20:10                           ` Stefan Monnier
2015-10-26  6:57                             ` Tassilo Horn
2015-10-25 18:43                       ` Eli Zaretskii
2015-10-24 12:46               ` Tassilo Horn
2015-10-25 14:43             ` Artur Malabarba
2015-10-25 18:50               ` Eli Zaretskii
2015-10-26  0:27                 ` Artur Malabarba [this message]
2015-10-26  3:32                   ` Eli Zaretskii
2015-10-26 13:43                     ` Tassilo Horn
2015-10-24 10:35         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdUY-J3rkqvvGJw5qrAM0rTnpjV4C94dqUYEDoxSLUZisR9-Q@mail.gmail.com \
    --to=bruce.connor.am@gmail.com \
    --cc=21747@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.