* bug#22089: installs packages with bad signatures
@ 2015-12-03 23:10 Glenn Morris
2015-12-04 0:14 ` Artur Malabarba
2015-12-04 8:12 ` Michael Albinus
0 siblings, 2 replies; 9+ messages in thread
From: Glenn Morris @ 2015-12-03 23:10 UTC (permalink / raw
To: 22089
Package: emacs
Version: 25.0.50
Severity: important
Emacs happily installs packages with bad gpg signatures.
This has been flagged by the test-suite and automated builds for the past
several weeks. (I feel like asking why we even have those things, for
all the attention they seem to get.)
This seems to be the first failure.
http://hydra.nixos.org/build/27800227
Here is the diff from the previous build, with several package changes:
http://hydra.nixos.org/api/scmdiff?type=git&rev2=937565268a5dc3377d4c9bff6d48eb3645a77160&rev1=70f1fda4ae6abb5e11dcf281738c25f6f5b06061&uri=git%3A%2F%2Fgit.sv.gnu.org%2Femacs.git&branch=
Here's a standalone recipe in the emacs-25 branch:
cd test/automated
mkdir /tmp/foo
HOME=/tmp/foo ../../src/emacs -Q
(setq package-archives `(("gnu" . ,(expand-file-name "data/package/signed/"))))
(package-import-keyring "data/package/key.pub")
(package-initialize)
(package-refresh-contents)
(package-install 'signed-bad)
M-x list-packages -> signed-bad installed
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-03 23:10 bug#22089: installs packages with bad signatures Glenn Morris
@ 2015-12-04 0:14 ` Artur Malabarba
2015-12-04 8:12 ` Michael Albinus
1 sibling, 0 replies; 9+ messages in thread
From: Artur Malabarba @ 2015-12-04 0:14 UTC (permalink / raw
To: Glenn Morris; +Cc: 22089
[-- Attachment #1: Type: text/plain, Size: 68 bytes --]
Thanks for the pointer, Glenn. I clearly messed something up there.
[-- Attachment #2: Type: text/html, Size: 86 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-03 23:10 bug#22089: installs packages with bad signatures Glenn Morris
2015-12-04 0:14 ` Artur Malabarba
@ 2015-12-04 8:12 ` Michael Albinus
2015-12-04 18:42 ` Glenn Morris
1 sibling, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2015-12-04 8:12 UTC (permalink / raw
To: Glenn Morris; +Cc: 22089
Glenn Morris <rgm@gnu.org> writes:
> Emacs happily installs packages with bad gpg signatures.
> This has been flagged by the test-suite and automated builds for the past
> several weeks. (I feel like asking why we even have those things, for
> all the attention they seem to get.)
Off-topic to this bug, but: hydra status mails to <emacs-buildstatus@gnu.org>
have been stopped three months ago. Maybe this could be reactivated;
people (like me) check this list.
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-04 8:12 ` Michael Albinus
@ 2015-12-04 18:42 ` Glenn Morris
2015-12-05 11:35 ` Artur Malabarba
2015-12-05 18:50 ` Hydra not sending "build broken" emails Dmitry Gutov
0 siblings, 2 replies; 9+ messages in thread
From: Glenn Morris @ 2015-12-04 18:42 UTC (permalink / raw
To: Michael Albinus; +Cc: 22089
Michael Albinus wrote:
> Off-topic to this bug, but: hydra status mails to <emacs-buildstatus@gnu.org>
> have been stopped three months ago. Maybe this could be reactivated;
> people (like me) check this list.
The place to ask about such things is the hydra-users mailing list.
I've asked about this specific issue several times.
The latest times I asked, I got no reply.
Perhaps they are tired of talking to me (so you could ask instead),
but I assume that for some reason the mail notification feature can't
be fixed and isn't coming back. It's a shame, but personally I just
check the web status page now and then instead.
But if hacking on foo.el, run foo-tests.el (at least) before pushing.
It's not rocket science.
Eg today I see that simple-test is trivially broken by recent changes
in simple.el.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-04 18:42 ` Glenn Morris
@ 2015-12-05 11:35 ` Artur Malabarba
2015-12-05 19:34 ` Artur Malabarba
2015-12-05 18:50 ` Hydra not sending "build broken" emails Dmitry Gutov
1 sibling, 1 reply; 9+ messages in thread
From: Artur Malabarba @ 2015-12-05 11:35 UTC (permalink / raw
To: Glenn Morris; +Cc: 22089, Michael Albinus
2015-12-04 18:42 GMT+00:00 Glenn Morris <rgm@gnu.org>:
> But if hacking on foo.el, run foo-tests.el (at least) before pushing.
> It's not rocket science.
> Eg today I see that simple-test is trivially broken by recent changes
> in simple.el.
FWIW, I always run the relevant tests before pushing. For some reason,
that specific test is always skipped on my system if I run it with
`make'. That's why I didn't catch that.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Hydra not sending "build broken" emails
2015-12-04 18:42 ` Glenn Morris
2015-12-05 11:35 ` Artur Malabarba
@ 2015-12-05 18:50 ` Dmitry Gutov
1 sibling, 0 replies; 9+ messages in thread
From: Dmitry Gutov @ 2015-12-05 18:50 UTC (permalink / raw
To: Glenn Morris, Michael Albinus; +Cc: emacs-devel
On 12/04/2015 08:42 PM, Glenn Morris wrote:
> The place to ask about such things is the hydra-users mailing list.
> I've asked about this specific issue several times.
> The latest times I asked, I got no reply.
> Perhaps they are tired of talking to me (so you could ask instead),
Michael has asked now:
http://lists.gnu.org/archive/html/hydra-users/2015-12/msg00000.html
But perhaps they're tired to talking to anybody: the mailing list
archives for the last few months look pretty much dead, except for your
emails.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-05 11:35 ` Artur Malabarba
@ 2015-12-05 19:34 ` Artur Malabarba
2015-12-06 9:01 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Artur Malabarba @ 2015-12-05 19:34 UTC (permalink / raw
To: Glenn Morris; +Cc: 22089, Michael Albinus
I push a fix for this today. Now waiting for the hydra build to run.
Is this the correct place to look? http://hydra.nixos.org/build/28513720
2015-12-05 11:35 GMT+00:00 Artur Malabarba <bruce.connor.am@gmail.com>:
> 2015-12-04 18:42 GMT+00:00 Glenn Morris <rgm@gnu.org>:
>> But if hacking on foo.el, run foo-tests.el (at least) before pushing.
>> It's not rocket science.
>> Eg today I see that simple-test is trivially broken by recent changes
>> in simple.el.
>
>
> FWIW, I always run the relevant tests before pushing. For some reason,
> that specific test is always skipped on my system if I run it with
> `make'. That's why I didn't catch that.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-05 19:34 ` Artur Malabarba
@ 2015-12-06 9:01 ` Michael Albinus
2015-12-06 14:01 ` Artur Malabarba
0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2015-12-06 9:01 UTC (permalink / raw
To: Artur Malabarba; +Cc: 22089
Artur Malabarba <bruce.connor.am@gmail.com> writes:
> I push a fix for this today. Now waiting for the hydra build to run.
> Is this the correct place to look? http://hydra.nixos.org/build/28513720
Not really. Start at <http://hydra.nixos.org/jobset/gnu/emacs-25>. There
you see, that there is still one failing test.
Follow <red 1> -> coverage -> Logfile: raw
At the end of the file, you see that package-test.log does not fail any
longer. If you perform the same exercise with a previous test run,
package-test.log was still mentioned to fail.
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#22089: installs packages with bad signatures
2015-12-06 9:01 ` Michael Albinus
@ 2015-12-06 14:01 ` Artur Malabarba
0 siblings, 0 replies; 9+ messages in thread
From: Artur Malabarba @ 2015-12-06 14:01 UTC (permalink / raw
To: Michael Albinus; +Cc: 22089-done
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
Ok, thanks Michael.
Closing this then.
[-- Attachment #2: Type: text/html, Size: 63 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-12-06 14:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-03 23:10 bug#22089: installs packages with bad signatures Glenn Morris
2015-12-04 0:14 ` Artur Malabarba
2015-12-04 8:12 ` Michael Albinus
2015-12-04 18:42 ` Glenn Morris
2015-12-05 11:35 ` Artur Malabarba
2015-12-05 19:34 ` Artur Malabarba
2015-12-06 9:01 ` Michael Albinus
2015-12-06 14:01 ` Artur Malabarba
2015-12-05 18:50 ` Hydra not sending "build broken" emails Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.