From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Oleh <ohwoeowho@gmail.com>
Cc: emacs-diffs@gnu.org, emacs-devel <emacs-devel@gnu.org>
Subject: Re: scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings
Date: Sat, 14 Feb 2015 10:00:01 -0200 [thread overview]
Message-ID: <CAAdUY-J0vxF1inwiOpaMmwGG7ea5FreoEmpqGLEeTg5Z4L3bnA@mail.gmail.com> (raw)
In-Reply-To: <87twyo93uf.fsf@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 485 bytes --]
Ok. Thanks for clarifying.
On 14 Feb 2015 10:36, "Oleh Krehel" <ohwoeowho@gmail.com> wrote:
> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> >>> + (with-current-buffer (find-file-noselect file)
> >>
> >> Please use with-temp-buffer + insert-file-contents instead.
> >
> > That is, unless the file needs to stay open for some specific reason.
>
> This file is already open - it's the file being checked currently. No
> need to close it or for temp buffers.
>
[-- Attachment #1.2: Type: text/html, Size: 853 bytes --]
prev parent reply other threads:[~2015-02-14 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150213140806.27897.63152@vcs.savannah.gnu.org>
[not found] ` <E1YMGud-0007H1-1V@vcs.savannah.gnu.org>
2015-02-13 20:17 ` [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom Stefan Monnier
2015-02-13 20:22 ` Oleh Krehel
2015-02-13 21:41 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
2015-02-15 11:09 ` Oleh Krehel
2015-02-18 9:03 ` Oleh Krehel
2015-02-24 16:20 ` Oleh Krehel
[not found] ` <E1YMGud-0007HA-HJ@vcs.savannah.gnu.org>
2015-02-13 21:49 ` [Emacs-diffs] scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings Artur Malabarba
2015-02-13 21:53 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
2015-02-14 12:00 ` Artur Malabarba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-J0vxF1inwiOpaMmwGG7ea5FreoEmpqGLEeTg5Z4L3bnA@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.