From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: What to do for faster `remove-duplicates'? Date: Wed, 6 May 2015 19:31:47 +0100 Message-ID: References: <87383atb2p.fsf@gmail.com> <873839ltoa.fsf@gmail.com> <87bnhxeh4j.fsf@gmail.com> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1430937119 16400 80.91.229.3 (6 May 2015 18:31:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 May 2015 18:31:59 +0000 (UTC) Cc: emacs-devel To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 06 20:31:54 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yq46s-0000L0-DJ for ged-emacs-devel@m.gmane.org; Wed, 06 May 2015 20:31:54 +0200 Original-Received: from localhost ([::1]:46699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq46r-0005f3-NJ for ged-emacs-devel@m.gmane.org; Wed, 06 May 2015 14:31:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq46n-0005el-FS for emacs-devel@gnu.org; Wed, 06 May 2015 14:31:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq46m-00036k-Gf for emacs-devel@gnu.org; Wed, 06 May 2015 14:31:49 -0400 Original-Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:36618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq46m-00036U-8h for emacs-devel@gnu.org; Wed, 06 May 2015 14:31:48 -0400 Original-Received: by lagv1 with SMTP id v1so13916895lag.3 for ; Wed, 06 May 2015 11:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=/4Rr8vXIckeV+4MJMQQpwu7R14FUIKwkmsmVbPYdPgU=; b=Jyyzcop6Oe/jQrKIhaz+cqFKWjlyycsLhXsSwiUodImTA+xcq8VMqluBRmGnaxuozP Com6i7/W/oMQIAUTIWoSW1HDJTjEOcS/1VH6F8sNVo1pNpVVuAfvakpXfdHheX9ARjzf 7cMurAYUTFdF0+7/QrqaQ9A1U6CzKie07obyYhCVCOKjHKryqYMuCyKhlIKvwJJRbxvl SbSIe8Y4WgStLeBKuwlFfmGYFvSJIBcR9erWUe7VknQYLbBl+wt7uO+82mfnwwZp7ZsV xDgxTZmMLlcqcsgSVm2eQrzQiiobpmlPyJJKy/2z3wX8zmTSysv/vC14cVyAeAm3nIOa khIA== X-Received: by 10.112.204.6 with SMTP id ku6mr25463lbc.73.1430937107287; Wed, 06 May 2015 11:31:47 -0700 (PDT) Original-Received: by 10.25.150.1 with HTTP; Wed, 6 May 2015 11:31:47 -0700 (PDT) In-Reply-To: <87bnhxeh4j.fsf@gmail.com> X-Google-Sender-Auth: qpY0qpjmwJfi0xS70IqKwIOPsGY X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186293 Archived-At: >> Looks good, please install. > > Not so good as now it is no more destructive for a seq > 100. Just pushed the following: modified lisp/subr.el @@ -424,12 +424,12 @@ one is kept." (unless (gethash elt hash) (puthash elt elt hash) (push elt res))) - (nreverse res)) + (setcdr list (cdr (nreverse res)))) (let ((tail list)) (while tail (setcdr tail (delete (car tail) (cdr tail))) - (setq tail (cdr tail)))) - list)) + (setq tail (cdr tail))))) + list)