From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#20241: 25.0.50; `setq' with only one argument Date: Tue, 24 Nov 2015 19:26:16 +0000 Message-ID: References: <16400d25-dff1-4bfb-b929-814714f9e20f@default> <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114069d4cabcc705254e5006 X-Trace: ger.gmane.org 1448393243 3147 80.91.229.3 (24 Nov 2015 19:27:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Nov 2015 19:27:23 +0000 (UTC) Cc: 20241@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 24 20:27:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1JF7-0000Fx-92 for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 20:27:09 +0100 Original-Received: from localhost ([::1]:40990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1JF8-0003Hr-CL for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 14:27:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1JF3-0003Hg-L4 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 14:27:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1JF0-0003O2-EW for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 14:27:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1JF0-0003Ny-B2 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 14:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a1JEz-0006gP-TQ for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 14:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Nov 2015 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20241-submit@debbugs.gnu.org id=B20241.144839319925647 (code B ref 20241); Tue, 24 Nov 2015 19:27:01 +0000 Original-Received: (at 20241) by debbugs.gnu.org; 24 Nov 2015 19:26:39 +0000 Original-Received: from localhost ([127.0.0.1]:51649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1JEc-0006fa-Nl for submit@debbugs.gnu.org; Tue, 24 Nov 2015 14:26:39 -0500 Original-Received: from mail-lf0-f44.google.com ([209.85.215.44]:35066) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1JEH-0006et-Ko for 20241@debbugs.gnu.org; Tue, 24 Nov 2015 14:26:36 -0500 Original-Received: by lfdl133 with SMTP id l133so33925255lfd.2 for <20241@debbugs.gnu.org>; Tue, 24 Nov 2015 11:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=YBTJ2lb/swro7LqUqaVIKKI7SewTNJpAA/Qq2j681Xk=; b=k34xiAYeg3xt4o0bzh8vz49++V66KfUmkRhx8YkNwGGrlSXSVITF7S8ujEcf78ewNK UM2176cmrnNRgf77A1HVH/wINkEaujLnpyy16HxMY3rcEcfRJstz+7qPwF0oj8bSNPg3 GjbD8E2V/HvXgA+TbBrT8A7U6oJhR6TdwALz9DBi5avnGh4XXnlOllv0s8zKYeYgti/F JVFB+ACjhZveySGgwSeHqGYVRk5uSyPG4DPbPblDE0md/hVGRBtyLuA85gANbfGDHeOg mcp8kmmfLI0qr68dOmYNuzRxP5PeJcHwIkpjUqsHZZvFYNXSfeOM7RtkbU78HKx0IkZH G69g== X-Received: by 10.25.19.69 with SMTP id j66mr14198131lfi.25.1448393176691; Tue, 24 Nov 2015 11:26:16 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Tue, 24 Nov 2015 11:26:16 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Tue, 24 Nov 2015 11:26:16 -0800 (PST) In-Reply-To: <20151124180452.GB1840@acm.fritz.box> X-Google-Sender-Auth: nSYr-hx1zeFyLie-TfzZ-5Nd33w X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109190 Archived-At: --001a114069d4cabcc705254e5006 Content-Type: text/plain; charset=UTF-8 On 24 Nov 2015 6:04 pm, "Alan Mackenzie" wrote: > There were, after all, only five uses of this > "feature" in the entire Emacs code base. And one of these was in > .../obsolete. A few months ago Stefan changed save-excursion to no longer restore the mark. IIRC (though I may be forgetting), there were zero uses of this in the codebase, and he even asked about it on the list and nobody said "I use this". Still, after the change was applied, some issues came up on a couple of highly used packages out there, and my guess is that more will come up once 25 is released. I'm not speaking against that change. It was a good change because it fixed more problems than it created. And the same is true here. This change will be good. However, if there are 5 uses of it in the core, then it's likely there are 30 or 100 uses of it in the wild. This change _will_ break things. So it is my opinion that it should go in the master branch. The feature freeze exists for a reason. The emacs 25 branch should only get the warning, instead. A warning really goes a long way, and it doesn't break anything. --001a114069d4cabcc705254e5006 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 24 Nov 2015 6:04 pm, "Alan Mackenzie" <acm@muc.de> wrote:
> There were, after all, only five uses of this
> "feature" in the entire Emacs code base.=C2=A0 And one of th= ese was in
> .../obsolete.

A few months ago Stefan changed save-excursion to no longer = restore the mark. IIRC (though I may be forgetting), there were zero uses o= f this in the codebase, and he even asked about it on the list and nobody s= aid "I use this".
Still, after the change was applied, some issues came up on a couple of hig= hly used packages out there, and my guess is that more will come up once 25= is released.

I'm not speaking against that change. It was a good chan= ge because it fixed more problems than it created. And the same is true her= e. This change will be good.

However, if there are 5 uses of it in the core, then it'= s likely there are 30 or 100 uses of it in the wild. This change _will_ bre= ak things. So it is my opinion that it should go in the master branch. The = feature freeze exists for a reason.

The emacs 25 branch should only get the warning, instead. A = warning really goes a long way, and it doesn't break anything.

--001a114069d4cabcc705254e5006--