From: Artur Malabarba <bruce.connor.am@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 20445 <20445@debbugs.gnu.org>
Subject: bug#20445: excessive redisplay / echo area resizing during byte-compilation
Date: Wed, 29 Apr 2015 09:56:09 +0100 [thread overview]
Message-ID: <CAAdUY-+FHgZF59vP0PiR3AoSgtB=BNWqyXeFhQ2m_RoDAhpcgg@mail.gmail.com> (raw)
In-Reply-To: <55408425.5020409@gmx.at>
2015-04-29 8:11 GMT+01:00 martin rudalics <rudalics@gmx.at>:
>> This is the problem: in order to "not emit a message" this code emits
>> the message and then immediately hides it by emitting "the empty
>> message" on top of it.
>>
>> Since `message' redisplays right away (rather than waiting for the next
>> "idle" moment to perform redisplay, as is the case for normal buffer
>> changes), this result in a lot of wasted work, and it won't truly do
>> what was intended:
>> - If your machine/display is slow enough, you will see it
>> - If your system "prints" messages by speaking them out loud (e.g. with
>> emacspeak) you will hear them.
>>
>> Why not just do:
>>
>> (when byte-compile--interactive
>> (apply #'message format args))
>>
>> ?
>
> But if there are no errors this would not display a message at all with
> Glenn's scenario. IMHO `byte-compile--interactive' puts the cart before
> the horse. Rather, displaying messages should be the default and the
> caller should be able to suppress them via a `byte-compile--no-message'
> variable or something the like. So I'd instead use
>
> (unless byte-compile--no-message
> (apply #'message format args)))
I just changed the current version to use `inhibit-messages' (sorry,
forgot to reference the bug in it). I implemented
`byte-compile--message' the way that made more sense to me, but I'm
perfectly fine with your suggestion as well.
Whatever we end up doing to it, please use `(let ((inhibit-messages
byte-compile--no-message) ...)' instead of `(unless
byte-compile--no-message ...)', as that will still log the messages
somwhere.
next prev parent reply other threads:[~2015-04-29 8:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 21:31 bug#20445: excessive redisplay / echo area resizing during byte-compilation Glenn Morris
2015-04-27 21:44 ` Glenn Morris
2015-04-28 9:33 ` martin rudalics
2015-04-28 14:26 ` martin rudalics
2015-04-28 15:22 ` Eli Zaretskii
2015-04-28 17:43 ` martin rudalics
2015-04-28 18:00 ` Eli Zaretskii
2015-04-29 7:11 ` martin rudalics
2015-04-28 15:13 ` Eli Zaretskii
2015-04-29 3:21 ` Stefan Monnier
2015-04-29 7:11 ` martin rudalics
2015-04-29 8:56 ` Artur Malabarba [this message]
2015-04-29 8:58 ` Artur Malabarba
2015-04-29 7:37 ` Artur Malabarba
2015-04-29 15:53 ` Eli Zaretskii
2015-04-29 18:35 ` Artur Malabarba
2015-04-29 18:52 ` Artur Malabarba
2015-05-01 10:41 ` martin rudalics
2015-05-01 12:20 ` Artur Malabarba
2015-05-01 13:45 ` martin rudalics
2015-05-01 14:19 ` Artur Malabarba
2015-05-01 16:28 ` Artur Malabarba
2015-05-02 8:58 ` martin rudalics
2015-05-01 10:41 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-+FHgZF59vP0PiR3AoSgtB=BNWqyXeFhQ2m_RoDAhpcgg@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=20445@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.