From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Suggest: dont declare interactive-p obsolete Date: Thu, 19 Nov 2015 08:39:15 +0000 Message-ID: References: Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1447922378 23962 80.91.229.3 (19 Nov 2015 08:39:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 08:39:38 +0000 (UTC) To: raman , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 09:39:38 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzKkU-0004rC-A2 for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 09:39:22 +0100 Original-Received: from localhost ([::1]:40183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzKkT-0007hE-Gz for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 03:39:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzKkP-0007gv-Tq for emacs-devel@gnu.org; Thu, 19 Nov 2015 03:39:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzKkP-00015m-46 for emacs-devel@gnu.org; Thu, 19 Nov 2015 03:39:17 -0500 Original-Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]:35668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzKkO-00015b-TG for emacs-devel@gnu.org; Thu, 19 Nov 2015 03:39:17 -0500 Original-Received: by lfdo63 with SMTP id o63so43178604lfd.2 for ; Thu, 19 Nov 2015 00:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=udfgOGicOP6buR9n5e2VDaDTQDp0l8bsU810Jp+xK5Y=; b=zYS0Rof+Z1VINxCOZhBR6Xf8kraCCXJjlo7HwY+MzD9BsFvSVr7RguKcxtz1ddoNNn ZNj3i4SXcZFwTx/51oylEQZbB3OjVf0wPRAAKjPsZaz/t1XcKJ86LfyvKmhi/zsQ9oj6 XmKOPOKKW1fXnPKgxArBbxSsbUUvLbbqkF3YTgKb59lcCI+ex34AoyYDn90EdkEhM+BA cyxnpyp2u4Clt5wXY7oFD1Z7QMXcuF0hbYer+tu9CnpX6bUhec16Pylzk1OKNY+e4qvY yxlWUz8vv7EyK6oHa/CqZITHb43M4jeJxqiZW4qIDE9jsRDg0t8IQAsFPCbGzzXfh/lz bD3A== X-Received: by 10.25.20.217 with SMTP id 86mr2695730lfu.164.1447922355922; Thu, 19 Nov 2015 00:39:15 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Thu, 19 Nov 2015 00:39:15 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: 2M6VRVkrCDF-TNqQWU-xbZOBCTc X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194777 Archived-At: 2015-11-19 4:16 GMT+00:00 John Wiegley : >>>>>> raman writes: > >> This is a minor change -- that will let existing code run without warnings. >> If we turned the defun in subr.el to a defsubst and dropped the (declare >> (obsolete called-interactively-p "23.2")) (called-interactively-p >> 'interactive)) > > I don't see any downsides to this; others? I wasn't here when this function was made obsolete, but I can think of a couple of downsides: 1. Code duplication (sure, the code is already duplicated, but by keeping it obsolete we can hopefully remove it soon). 2. The name interactive-p makes it sound like it's equivalent to `(not noninteractive)', which determines whether Emacs itself (not the function) is running interactively. While `called-interactively-p' is more obviously about how the function was called. By my estimates, this function was made obsolete 5 years ago. And it _is_ obsolete. IMHO, packages that try to support Emacs releases 6 years apart (as noble as that is) can't expect to be able to do that without a few warnings. There are ways for such packages to suppress these warnings. But it's important to keep them to prevent this function from spreading.