From: Artur Malabarba <bruce.connor.am@gmail.com>
To: raman <raman@google.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Suggest: dont declare interactive-p obsolete
Date: Thu, 19 Nov 2015 08:39:15 +0000 [thread overview]
Message-ID: <CAAdUY-+BqBmS07MxBt-V04vNTSHR6qHTW_3LnJ+THcxJzingwQ@mail.gmail.com> (raw)
In-Reply-To: <m24mgi7hey.fsf@newartisans.com>
2015-11-19 4:16 GMT+00:00 John Wiegley <jwiegley@gmail.com>:
>>>>>> raman <raman@google.com> writes:
>
>> This is a minor change -- that will let existing code run without warnings.
>> If we turned the defun in subr.el to a defsubst and dropped the (declare
>> (obsolete called-interactively-p "23.2")) (called-interactively-p
>> 'interactive))
>
> I don't see any downsides to this; others?
I wasn't here when this function was made obsolete, but I can think of
a couple of downsides:
1. Code duplication (sure, the code is already duplicated, but by
keeping it obsolete we can hopefully remove it soon).
2. The name interactive-p makes it sound like it's equivalent to `(not
noninteractive)', which determines whether Emacs itself (not the
function) is running interactively. While `called-interactively-p' is
more obviously about how the function was called.
By my estimates, this function was made obsolete 5 years ago. And it
_is_ obsolete.
IMHO, packages that try to support Emacs releases 6 years apart (as
noble as that is) can't expect to be able to do that without a few
warnings. There are ways for such packages to suppress these warnings.
But it's important to keep them to prevent this function from
spreading.
next prev parent reply other threads:[~2015-11-19 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 1:57 Suggest: dont declare interactive-p obsolete raman
2015-11-19 4:16 ` John Wiegley
2015-11-19 8:39 ` Artur Malabarba [this message]
2015-11-19 13:06 ` Andreas Röhler
2015-11-19 13:46 ` Dmitry Gutov
2015-11-20 7:29 ` Andreas Röhler
2015-11-19 13:44 ` Dmitry Gutov
2015-11-19 15:29 ` Eli Zaretskii
2015-11-19 16:25 ` John Wiegley
2015-11-19 17:32 ` raman
2015-11-19 17:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-+BqBmS07MxBt-V04vNTSHR6qHTW_3LnJ+THcxJzingwQ@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.