Re: package-install-from-buffer moves point

[Artur Malabarba <bruce.connor.am@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

2015-11-07 18:03 GMT+00:00 Peter Eisentraut <peter@eisentraut.org>:
>
> On 7/19/15 1:06 PM, Artur Malabarba wrote:
> >>> This is due to calls to some `lm-*' functions inside
> >>> `package-buffer-info' (possibly one of the calls I added myself
> >>> yesterday). I can just wrap those in save-excursions, but I'm thinking
> >>> that the `lm-*' functions themselves should not be moving the point.
> >>> Shall I use save-excursion inside those functions instead?
> >>
> >> Well, there is also a goto-char call right at the top of
> >> package-buffer-info.
> >
> > Clearly I should stop replying to messages on my phone where I can't
> > look at the code first. :)
> >
> >> But I agree that the lm-* functions should
> >> probably save the point themselves, too. There are some calls to
> >> save-excursion in lisp-mnt.el, but it seems it's not applied
consistently.
> >
> > Yes. `lm-header' always moves point to the header (besides returning
> > it). All the others I looked through seem to be fine.
>
> Did you (or someone) have a chance to work on this?

Regrettably, no.
Feel free to do it if you'd like. It's really just a matter of fixing the
tests that fail when you save excursion.

[-- Attachment #2: Type: text/html, Size: 1585 bytes --]