From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add json-sexp-mode. Date: Sat, 17 Oct 2015 18:19:09 +0100 Message-ID: References: <87wpulwje2.fsf@T420.taylan> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11410d94361ab60522501c4f X-Trace: ger.gmane.org 1445102376 21187 80.91.229.3 (17 Oct 2015 17:19:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Oct 2015 17:19:36 +0000 (UTC) Cc: emacs-devel To: =?UTF-8?B?VGF5bGFuIFVscmljaCBCYXnEsXJsxLEvS2FtbWVy?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 17 19:19:28 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZnV8f-0007eY-V5 for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 19:19:26 +0200 Original-Received: from localhost ([::1]:59218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnV8f-0001ip-Ei for ged-emacs-devel@m.gmane.org; Sat, 17 Oct 2015 13:19:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnV8R-0001hx-Te for emacs-devel@gnu.org; Sat, 17 Oct 2015 13:19:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnV8Q-0004SY-Va for emacs-devel@gnu.org; Sat, 17 Oct 2015 13:19:11 -0400 Original-Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:33912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnV8Q-0004Ro-NG for emacs-devel@gnu.org; Sat, 17 Oct 2015 13:19:10 -0400 Original-Received: by lfaz124 with SMTP id z124so91311512lfa.1 for ; Sat, 17 Oct 2015 10:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=fabSpBRynpbTqkzeCdvjDgrb9q/ZUXSdwIhcxLzMJzs=; b=iDQ7MnoiBx6MDGBNZSigyGQzRv35bLnRqjDxH0NlBS3VhEZ4TdiqTeFkWTr5sNGE++ vL2jXY0iHHqhKrFtUlaHWncvddcRvXKreCvunopS74EEg5rKcHgJyTsWXH3U5jhyYLey INgMUAXoiP3P1lU5cRiNiHLonL9u6C1n++VQWIkjpECiNgtkdUWTwb+li+Rtw4S+BvG/ WXZ14IocqJBWZ7msgt8SGhu8YF7Wd/x4MOnkRP0lZgf+CzKSH+pGfaSRqgiuaMwP0eDk 54wrnevRSqgQY3463DNi6J+6pCWqoJCaKqyqXj/L64v2EHmAVXvzzwc+kMGOgRURrZbE Zwwg== X-Received: by 10.25.41.79 with SMTP id p76mr7153682lfp.16.1445102349587; Sat, 17 Oct 2015 10:19:09 -0700 (PDT) Original-Received: by 10.25.22.197 with HTTP; Sat, 17 Oct 2015 10:19:09 -0700 (PDT) Original-Received: by 10.25.22.197 with HTTP; Sat, 17 Oct 2015 10:19:09 -0700 (PDT) In-Reply-To: <87wpulwje2.fsf@T420.taylan> X-Google-Sender-Auth: uDD7dLfRBqOFoMDrUif595o37RM X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191859 Archived-At: --001a11410d94361ab60522501c4f Content-Type: text/plain; charset=UTF-8 > +;; Note that `json-sexp-mode' inherits from `emacs-lisp-mode' since it's for > +;; editing JSON data as Elisp s-expressions. It might be more appropriate to inherit from lisp-mode, which is parent to emacs-lisp-mode. It should still provide all of the syntax definitions you need without carrying a lot of key binds that don't make sense for your mode (like eval-defun or eval-last-sexp). I'm not sure which version of emacs added this mode, so you might have to add a dependency on emacs 24.3 or something like that. --001a11410d94361ab60522501c4f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> +;; Note that `json-sexp-mode' inherits from `emacs= -lisp-mode' since it's for
> +;; editing JSON data as Elisp s-expressions.

It might be more appropriate to inherit from lisp-mode, whic= h is parent to emacs-lisp-mode. It should still provide all of the syntax d= efinitions you need without carrying a lot of key binds that don't make= sense for your mode (like eval-defun or eval-last-sexp).

I'm not sure which version of emacs added this mode, so = you might have to add a dependency on emacs 24.3 or something like that. --001a11410d94361ab60522501c4f--