From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#22991: 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area Date: Fri, 11 Mar 2016 19:22:31 -0300 Message-ID: References: <83ziu4hh1r.fsf@gnu.org> <83wpp8hgdy.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c07e420ffda9f052dcd5d19 X-Trace: ger.gmane.org 1457735002 32076 80.91.229.3 (11 Mar 2016 22:23:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2016 22:23:22 +0000 (UTC) Cc: 22991@debbugs.gnu.org To: Kaushal Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 11 23:23:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aeVSh-00022E-G1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Mar 2016 23:23:11 +0100 Original-Received: from localhost ([::1]:57977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeVSg-000891-PJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Mar 2016 17:23:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeVSc-00086Q-RZ for bug-gnu-emacs@gnu.org; Fri, 11 Mar 2016 17:23:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeVSX-00052w-Sd for bug-gnu-emacs@gnu.org; Fri, 11 Mar 2016 17:23:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeVSX-00052m-PK for bug-gnu-emacs@gnu.org; Fri, 11 Mar 2016 17:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aeVSX-00013m-LL for bug-gnu-emacs@gnu.org; Fri, 11 Mar 2016 17:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Mar 2016 22:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22991 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22991-submit@debbugs.gnu.org id=B22991.14577349594047 (code B ref 22991); Fri, 11 Mar 2016 22:23:01 +0000 Original-Received: (at 22991) by debbugs.gnu.org; 11 Mar 2016 22:22:39 +0000 Original-Received: from localhost ([127.0.0.1]:45541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aeVSA-00013B-VV for submit@debbugs.gnu.org; Fri, 11 Mar 2016 17:22:39 -0500 Original-Received: from mail-yw0-f181.google.com ([209.85.161.181]:34692) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aeVS9-000130-Ll for 22991@debbugs.gnu.org; Fri, 11 Mar 2016 17:22:37 -0500 Original-Received: by mail-yw0-f181.google.com with SMTP id h129so107006251ywb.1 for <22991@debbugs.gnu.org>; Fri, 11 Mar 2016 14:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc; bh=Q7b1kxFRv+u5OQZl1m2oj/sWy3/P75awEmFSdXoJeJY=; b=Vf+Q1KhtDUVyByhDYBMTSjrA3GrH2JD6pMm3lMF+bvYuQFTR59RDAZnWx2e+BX3YdN ifXBaOAWEA9MfEeKqvWHBee++lIMk41cJu6PZc6kKNFyVQQCarPn91EOspi4J8TFPDJU /Q7nNIzgKB/5tAwdltVXp7vOFq9JhXB5K/Z5B1S8IH6pIxWT9lyLdYfM4+3PkjryTuug 5pkw/13CAaGxHFoBlChvt8/x3ldHlBddbDZzdPALC53/xeTLNZjIrQiC913c6gTfpj+K cfoX7S3IXRZ20qj4tN4nG8RXZFrLWc+y8JZ/zIcjm8v+nUjZxQ/fv8Yc2ddU66PuuJYB oGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:sender:in-reply-to :references:date:message-id:subject:from:to:cc; bh=Q7b1kxFRv+u5OQZl1m2oj/sWy3/P75awEmFSdXoJeJY=; b=Y1o91k+uel6nCL2uLz8rT7mpAsocMiNaop125OFmnyCSZlYIb9W2mDF/Lkdzvs1uMX OXrSNQfKpO1evQxyMu7Vcgpe6SarpmPjmai+qtL9aUihMJOPccJqAaye4O/uKtQ1Evjp ecOZ5czSYWcCOlBYGVAtUgQfh8Y1WZKSvkwV91rBC+/CfBwoMmoF4vioaf8qdOcWrSQq LfpEPtsgeGkB980OgniQ78fUyFW4WEy8a6Ij/D+G4d5zmfkwfNrI07FKvtYnmyJHgWUW yNu1Gx0hLNNb8E7cdmH+FZU4SJRQaUaJHo0XqFfoQNNRqt7AxoplDdZi25YW9+XIKtaw ichQ== X-Gm-Message-State: AD7BkJLWoeCNFYrEnjEoUgtJWVOrnZP7Cb036q7DTnFcVlcvICvV/aIr2mU8Rb39QVY8BH2kh1MwceBx4UWOiw== X-Received: by 10.13.251.135 with SMTP id l129mr6302738ywf.283.1457734952145; Fri, 11 Mar 2016 14:22:32 -0800 (PST) Original-Received: by 10.129.31.5 with HTTP; Fri, 11 Mar 2016 14:22:31 -0800 (PST) Original-Received: by 10.129.31.5 with HTTP; Fri, 11 Mar 2016 14:22:31 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: RxraWt_lFy9Lg6KV-U6v2XKMUys X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114795 Archived-At: --94eb2c07e420ffda9f052dcd5d19 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11 Mar 2016 6:23 pm, "Kaushal Modi" wrote: > > > Which I think is wrong, since the default mode shouldn't show anything > > except "I-search: ". Right? > Even before this patch, that behavior (Displaying "Regexp I-search:" on C-s even when search-default-mode is t) was that way. Because, even when search-default-mode is t, regexp-function still stays nil. So that first cond form condition evals to nil. > > But I discovered a major issue with my patch. So here's a new one which is less intrusive. I also added explanation for the current priority order in the cond. This last patch looks fine to me. =F0=9F=91=8D --94eb2c07e420ffda9f052dcd5d19 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 11 Mar 2016 6:23 pm, "Kaushal Modi" <kaushal.modi@gmail.com> wrote: >
> > Which I think is wrong, since the default mode shouldn't show= anything
> > except "I-search: ".=C2=A0 Right?

> Even before this patch, that behavior (Displaying "= ;Regexp I-search:" on C-s even when search-default-mode is t) was that= way. Because, even when search-default-mode is t, regexp-function still st= ays nil. So that first cond form condition evals to nil.
>
> But I discovered a major issue with my patch. So here's a new one = which is less intrusive. I also added explanation for the current priority = order in the cond.

This last patch looks fine to me. =F0=9F=91=8D

--94eb2c07e420ffda9f052dcd5d19--