From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b6610d5 2/4: emacs-lisp/package.el: Refactor pre-execute prompt Date: Mon, 6 Apr 2015 16:22:28 +0100 Message-ID: References: <20150406102057.929.89886@vcs.savannah.gnu.org> <5522653C.5010608@yandex.ru> <837ftpldok.fsf@gnu.org> <83r3rxjqbx.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1428333758 29016 80.91.229.3 (6 Apr 2015 15:22:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Apr 2015 15:22:38 +0000 (UTC) Cc: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 06 17:22:36 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yf8rD-0004lW-9x for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2015 17:22:35 +0200 Original-Received: from localhost ([::1]:40539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yf8rC-0008Bh-OX for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2015 11:22:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yf8r8-0008BZ-So for emacs-devel@gnu.org; Mon, 06 Apr 2015 11:22:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yf8r8-0002yM-1r for emacs-devel@gnu.org; Mon, 06 Apr 2015 11:22:30 -0400 Original-Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:34661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yf8r7-0002yC-QI for emacs-devel@gnu.org; Mon, 06 Apr 2015 11:22:29 -0400 Original-Received: by lboc7 with SMTP id c7so21993336lbo.1 for ; Mon, 06 Apr 2015 08:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:cc:content-type:content-transfer-encoding; bh=dtfo/WUha07m1GK/8aAVpIIbapuizxTyVwV50TRVGEQ=; b=B5kNsKNzHytiAVSmTSeXA5VLFVKfCeaMRh9vCBbO1i/IsaDqE8u25ZMEyRApF4cWN9 OVhu9q/09uMASeOLSp7ro/y5rFODgiHmWlqY91XyO3PLVqJZz2e4nf3U2U5MlQfOq+ph D0wba1DLMFAGwuBXolbvPi33UDkwqI1hPkN9ErDdJZ75qUFIrg1gFcG0S+lJqpHjRtXx N0V17RzmW3xiIX0wBBpO7XoSr2iSI2g2ClVbh3GiHn68S2jYjQJe38J6sxcfbVyavRwC toyVdy9xQwAg17b51Fm9PKXRyacqUeCvsDZ31NCjhnn2MUayfp4q/GPIORs/Ic437ulY p9Kw== X-Received: by 10.152.45.101 with SMTP id l5mr13511088lam.95.1428333748988; Mon, 06 Apr 2015 08:22:28 -0700 (PDT) Original-Received: by 10.25.150.131 with HTTP; Mon, 6 Apr 2015 08:22:28 -0700 (PDT) In-Reply-To: <83r3rxjqbx.fsf@gnu.org> X-Google-Sender-Auth: hcGafizdJ4KH7Hzq-uHjcrcXKt0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185042 Archived-At: > What I would do in this situation is work on a branch, make > fine-grained commits there, and then merge them all onto master in a > single merge-commit. Then, if someone follows first-parent, they'd > see a single commit with the feature, while still being able to > discern the separate commits you made during development. Thanks, I like that idea. > No, it's a judgment call. For me, an important question that helps > the decision is "will I ever want to revert that single changeset?" > YMMV, most probably. Ok. The question I usually ask myself is =E2=80=9CIs it conceivable this changeset might intruduce a bug?=E2=80=9D This way tools like git bisect become considerably more useful (not that I've ever had to use it for Emacs specifically).