From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Manheimer Newsgroups: gmane.emacs.bugs Subject: bug#42233: 28.0.50; Fix lisp/allout-widgets.el too-shallow successor decoration problem Date: Mon, 6 Jul 2020 14:37:57 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000765a9405a9ca2d02" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12673"; mail-complaints-to="usenet@ciao.gmane.io" To: 42233@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 06 20:39:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jsW1H-00031i-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jul 2020 20:39:11 +0200 Original-Received: from localhost ([::1]:60062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsW1G-0002Dw-6C for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jul 2020 14:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsW18-0002Da-PU for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 14:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsW18-0006rA-Gu for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 14:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsW18-00060i-Ep for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Manheimer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jul 2020 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42233 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.159406070023024 (code B ref -1); Mon, 06 Jul 2020 18:39:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jul 2020 18:38:20 +0000 Original-Received: from localhost ([127.0.0.1]:34854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsW0S-0005zH-DT for submit@debbugs.gnu.org; Mon, 06 Jul 2020 14:38:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsW0R-0005zA-6V for submit@debbugs.gnu.org; Mon, 06 Jul 2020 14:38:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsW0Q-0002Bg-Vw for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 14:38:19 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:40474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsW0O-0006nF-Pm for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2020 14:38:18 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id f139so43153536wmf.5 for ; Mon, 06 Jul 2020 11:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=kRbsSmyv8ZLFUgPMvf+fvgzbg6qSCcMH/M/UJTGt09Y=; b=hPS1neTs6c5gYKwGdZxSEJ3skjOAwF89DRotvIPNgihZXmeevwdLEyefto+Ers0bIs awIoOj+ZNe2kJV+xvopV/gTsdLUcwJStiEF8H+x2uCme0TnMG5mfmhpFpCzQTT1C64g5 SWt4i5gyDd1tOpGea8e6UhjFN6LkqzWGFXhhww6zWbwMq18rxsEW75ULVW9tQ6vlKioW Iqg2VHeFx94yDVAYKnZh+8nhqvr77HzrA0n71EV0OTRhyZk1X/QLvCV1zW/7VU+o+YH9 Zp60Xe6J5E96GVSYUXodecOHFCy+quFBS5SI6ZnpnaU07DnEfyc30IU+j4Kk2nGhc0NM DVBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kRbsSmyv8ZLFUgPMvf+fvgzbg6qSCcMH/M/UJTGt09Y=; b=E1LLnuVHdRVu/pOm5IfpDHQKY7rK5I1V3c6g51jOQATx/DnEUu+OxH9VNJMn/gSHrm alp22OhLIKHuDjMZ0YUTeAF8OW1zZLTauBRuWVatSYYIdP49Y+5gtu/ynOamdEfsf1Vf WL62/xopSiTFOZVLmRZXchEqxrsVzLCxIQzsnhOyT0OfmWP0fcZ3BTHjWzX8RHols89s bSVKiGvh5f0RqozE2J0zVHD2DTT93PD9Gh0x5WMKGzNi1XVBX5L4P4HGkXVSs1P2L1Fl HHidirOHRfqA89qY2FNUHnqAsA60qm/cvzh0+yVk0b+WkqjjhFE9yTEl0uTloqdapdof 9DBg== X-Gm-Message-State: AOAM530/DckXPA1l+N901pnIyGS7Awyn593HTSCz4Fx/5ZW+WSac7Uco /MryJ30EemOIA02uXNfTE5N7Xa4//l2MTFYuK6pEiuSdL5U= X-Google-Smtp-Source: ABdhPJzp0txEDFYJfwZ0oE80TlsNQGsWYYRfgBjdD/FlGld1FfFIvGy1eG2R4AmL6pSBDFdEJj0Kug/XbnEyQ1NZc4U= X-Received: by 2002:a1c:bc8a:: with SMTP id m132mr470651wmf.1.1594060694759; Mon, 06 Jul 2020 11:38:14 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=ken.manheimer@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182768 Archived-At: --000000000000765a9405a9ca2d02 Content-Type: multipart/alternative; boundary="000000000000765a9205a9ca2d00" --000000000000765a9205a9ca2d00 Content-Type: text/plain; charset="UTF-8" In the current version of lisp/allout-widgets, the process of decorating a succession of items is disrupted if an item is encountered at a level shallower than any prior item in the file. The attached patch prevents that disruption, enabling the decoration process to continue subsequent to the too-shallow item. (Ideally it should also decorate the aberrant item, but this patch does not achieve that.) It so happens that allout-widgets.el itself provides a fine example of the problem. Visit the file then activate allout-mode followed by allout-widgets-mode. The allout-widgets decoration process will get an error, reported in the mode line as "Wrong type argument: integer-or-marker-p, nil", and in *Messages* as "allout-get-or-create-item-widget: Wrong type argument: integer-or-marker-p, nil", and the Local emacs vars topic will be entirely undecorated. That attached fix could prevent the error and cause the contents of the Local emacs vars topic to be decorated, but not the topic itself. The patch also increases the depth of the topic so it is consistent with the preceeding topics. In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2020-07-04 built on gram Repository revision: 5d1bac0ac951e25d0b0b39a9919f13053162d5df Repository branch: master Windowing system distributor 'HC-Consult', version 11.0.12005001 System Description: Ubuntu 18.04.4 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. user-error: Minibuffer window is not active Configured using: 'configure --with-gnutls=ifavailable --with-x-toolkit=yes --with-xpm=ifavailable --with-jpeg=ifavailable --with-gif=ifavailable --with-tiff=ifavailable' Configured features: PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER Important settings: value of $LANG: C.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 46910 7577) (symbols 48 6117 1) (strings 32 15556 1866) (string-bytes 1 510277) (vectors 16 9360) (vector-slots 8 127308 9687) (floats 8 20 27) (intervals 56 184 0) (buffers 992 11)) --000000000000765a9205a9ca2d00 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
In the current version of lisp/allout-widgets, the pr= ocess of decorating a succession of items is disrupted if an item is encoun= tered at a level shallower than any prior item in the file. The attached pa= tch prevents that disruption, enabling the decoration process to continue s= ubsequent to the too-shallow item. (Ideally it should also decorate the abe= rrant item, but this patch does not achieve that.)

It so happens tha= t allout-widgets.el itself provides a fine example of the problem. Visit th= e file then activate allout-mode followed by allout-widgets-mode. The allou= t-widgets decoration process will get an error, reported in the mode line a= s "Wrong type argument: integer-or-marker-p, nil", and in *Messag= es* as "allout-get-or-create-item-widget: Wrong type argument: integer= -or-marker-p, nil", and the Local emacs vars topic will be entirely un= decorated.

That attached fix could prevent the error and cause the c= ontents of the Local emacs vars topic to be decorated, but not the topic it= self. The patch also increases the depth of the topic so it is consistent w= ith the preceeding topics.

In GNU Emacs 28.0.50 (bui= ld 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10)
= =C2=A0of 2020-07-04 built on gram
Repository revision: 5d1bac0ac951e25d0= b0b39a9919f13053162d5df
Repository branch: master
Windowing system di= stributor 'HC-Consult', version 11.0.12005001
System Description= : Ubuntu 18.04.4 LTS

Recent messages:
For information about GNU E= macs and the GNU system, type C-h C-a.
user-error: Minibuffer window is = not active
Configured using:
=C2=A0'configure --with-gnutls=3Difa= vailable --with-x-toolkit=3Dyes
=C2=A0--with-xpm=3Difavailable --with-jp= eg=3Difavailable --with-gif=3Difavailable
=C2=A0--with-tiff=3Difavailabl= e'

Configured features:
PNG CAIRO SOUND DBUS GSETTINGS GLIB N= OTIFY INOTIFY FREETYPE HARFBUZZ
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE X= IM MODULES THREADS PDUMPER

Important settings:
=C2=A0 value of $L= ANG: C.UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: = Fundamental

Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2= =A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-= wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2= =A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 b= link-cursor-mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encry= ption-mode: t
=C2=A0 auto-compression-mode: t
=C2=A0 buffer-read-only= : t
=C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t

L= oad-path shadows:
None found.

Features:
(shadow sort mail-extr= emacsbug message rmc puny dired dired-loaddefs
rfc822 mml easymenu mml-= sec password-cache epa derived epg epg-config
gnus-util rmail rmail-load= defs text-property-search time-date subr-x seq
byte-opt gv bytecomp byte= -compile cconv mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbr= ev gmm-utils mailheader cl-loaddefs cl-lib
sendmail rfc2047 rfc2045 ietf= -drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify edi= ff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win= x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list repla= ce newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab= -bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock= font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl= -generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-= viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak c= zech european
ethiopic indian cyrillic chinese composite charscript char= prop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-= preloaded nadvice loaddefs button faces cus-face macroexp files
text-pro= perties overlay sha1 md5 base64 format env code-pages mule
custom widget= hashtable-print-readable backquote threads dbusbind
inotify dynamic-set= ting system-font-setting font-render-setting cairo
move-toolbar gtk x-to= olkit x multi-tty make-network-process emacs)

Memory information:((conses 16 46910 7577)
=C2=A0(symbols 48 6117 1)
=C2=A0(strings 32 = 15556 1866)
=C2=A0(string-bytes 1 510277)
=C2=A0(vectors 16 9360)
= =C2=A0(vector-slots 8 127308 9687)
=C2=A0(floats 8 20 27)
=C2=A0(inte= rvals 56 184 0)
=C2=A0(buffers 992 11))
--000000000000765a9205a9ca2d00-- --000000000000765a9405a9ca2d02 Content-Type: application/octet-stream; name="0001-Don-t-let-item-decoration-be-disrupted-by-too-shallo.patch" Content-Disposition: attachment; filename="0001-Don-t-let-item-decoration-be-disrupted-by-too-shallo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcau5kfz0 RnJvbSBiYjFjYzEyMDhjY2ZjNmQyNDViMGZjOWRmZGMxY2ZjMGNkYTg2ODIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gTWFuaGVpbWVyIDxrZW4ubWFuaGVpbWVyQGdtYWlsLmNv bT4KRGF0ZTogTW9uLCA2IEp1bCAyMDIwIDE0OjE4OjU3IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0g RG9uJ3QgbGV0IGl0ZW0gZGVjb3JhdGlvbiBiZSBkaXNydXB0ZWQgYnkgdG9vLXNoYWxsb3cgaXRl bXMuCgoqIGxpc3AvYWxsb3V0LXdpZGdldHMuZWwgKGFsbG91dC1kZWNvcmF0ZS1pdGVtLWFuZC1j b250ZXh0KTogQ2hlY2sgZm9yCnBhcmVudC1wb3NpdGlvbiBoYXZpbmcgdmFsdWUgYmVmb3JlIHVz aW5nIGl0LgoKQWxzbywgc2hpZnQgbG9jYWwgZW1hY3MgdmFycyB0b3BpYyBkZWVwZXIgc28gaXQg ZG9lc24ndCBjb25zdGl0dXRlCmFuIGluc3RhbmNlIG9mIHRoYXQgcGFydGljdWxhciBhYmVycmFu dCBjYXNlLgotLS0KIGxpc3AvYWxsb3V0LXdpZGdldHMuZWwgfCAxMyArKysrKysrKy0tLS0tCiAx IGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2xpc3AvYWxsb3V0LXdpZGdldHMuZWwgYi9saXNwL2FsbG91dC13aWRnZXRzLmVsCmluZGV4 IGZiZGRkY2E3ZDcuLjBiODVmYjgzMWUgMTAwNjQ0Ci0tLSBhL2xpc3AvYWxsb3V0LXdpZGdldHMu ZWwKKysrIGIvbGlzcC9hbGxvdXQtd2lkZ2V0cy5lbApAQCAtMTU5NCw3ICsxNTk0LDEwIEBAIGFs bG91dC1kZWNvcmF0ZS1pdGVtLWFuZC1jb250ZXh0CiAgICAgICAoaWYgaXMtY29udGFpbmVyCiAg ICAgICAgICAgKHByb2duICh3aWRnZXQtcHV0IGl0ZW0td2lkZ2V0IDppcy1jb250YWluZXIgdCkK ICAgICAgICAgICAgICAgICAgKHNldHEgcmV2ZXJzZS1zaWJsaW5ncy1jaGFydCAobGlzdCAxKSkp Ci0gICAgICAgIChnb3RvLWNoYXIgKHdpZGdldC1hcHBseSBwYXJlbnQgOmFjdHVhbC1wb3NpdGlv biA6ZnJvbSkpCisgICAgICAgIChsZXQgKChwYXJlbnQtcG9zaXRpb24gKHdpZGdldC1hcHBseSBw YXJlbnQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDphY3R1 YWwtcG9zaXRpb24gOmZyb20pKSkKKyAgICAgICAgICAod2hlbiBwYXJlbnQtcG9zaXRpb24KKyAg ICAgICAgICAgIChnb3RvLWNoYXIgcGFyZW50LXBvc2l0aW9uKSkpCiAgICAgICAgIChpZiAod2lk Z2V0LWdldCBwYXJlbnQgOmlzLWNvbnRhaW5lcikKICAgICAgICAgICAgIDs7IGBhbGxvdXQtZ290 by1wcmVmaXgnIHdpbGwgZ28gdG8gZmlyc3Qgbm9uLWNvbnRhaW5lciBpdGVtOgogICAgICAgICAg ICAgKGFsbG91dC1nb3RvLXByZWZpeCkKQEAgLTIzODksNyArMjM5Miw3IEBAIGFsbG91dC13aWRn ZXRzLXJ1bi11bml0LXRlc3RzCiA7OztfIDogcHJvdmlkZQogKHByb3ZpZGUgJ2FsbG91dC13aWRn ZXRzKQogCi07OztfLiBMb2NhbCBlbWFjcyB2YXJzLgotOzs7XyAsIExvY2FsIHZhcmlhYmxlczoK LTs7O18gLCBhbGxvdXQtbGF5b3V0OiAoLTEgOiAwKQotOzs7XyAsIEVuZDoKKzs7O18gLiBMb2Nh bCBlbWFjcyB2YXJzLgorOzs7XyAgLCBMb2NhbCB2YXJpYWJsZXM6Cis7OztfICAsIGFsbG91dC1s YXlvdXQ6ICgtMSA6IDApCis7OztfICAsIEVuZDoKLS0gCjIuMTcuMQoK --000000000000765a9405a9ca2d02--