From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Manheimer Newsgroups: gmane.emacs.devel Subject: Re: Current documentation of current emacs patch-submission procedures? Date: Sun, 5 Jul 2020 12:35:37 -0400 Message-ID: References: <831rlqszfw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003d710f05a9b45ae5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17827"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 05 18:36:50 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1js7dK-0004Ze-Id for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jul 2020 18:36:50 +0200 Original-Received: from localhost ([::1]:51070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js7dJ-0005xu-Ke for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jul 2020 12:36:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1js7cX-0005YI-1U for emacs-devel@gnu.org; Sun, 05 Jul 2020 12:36:01 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:39892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1js7cV-0000Ez-DV; Sun, 05 Jul 2020 12:36:00 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id w3so26670028wmi.4; Sun, 05 Jul 2020 09:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tsYeMdDhqoNv+1QOJJLFC9/CJNXFIJ+/5TuaUr2X1Mc=; b=Z9xPtiJWsYNe2b0KzUcitnmpElmNlN6KCpjQtS7WSncbRuKcvOgxTttGsWGSQG1Hbk kplWaDrEUn7PTLhxl76N9Zn6VLWb7ewXVL4buIk+EGhs7Sh4oXPbaW3vvnAtmmk23G0O VzPWU/+RjTyOmLa7ASTn7tvHD7pzntm4EcRdV+AFVKR7N8pGq/LvY9sUd09VYTzvM4Fx 7CJDveTW5/nDLHAvZFiiWNClNk43xdze+fHEdnqnB/kqiASbj5pCK6fCGb5CDhSUcf+U WyCmdJPVFA/SAfOEQNSXSzMt6gpBnoOTNN7/bNyT0DBONL1CyGXQvR+p21qcOYNSmhTh ZcCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tsYeMdDhqoNv+1QOJJLFC9/CJNXFIJ+/5TuaUr2X1Mc=; b=NogrWw2Wmhms7P+rNVs0xH91uXkgKbPX5y9pLh+livtNKOMpjglRMNUL0nwCsJJofu y5vpH8kHj++OBIDDJ/ibdnsMHHm8Lf5nbRVFXgkS6x1ZbEETL9fuKJA64PrJMRvDtZWK ig59GGtyIeycsyqgpYyV+7gyMi4djLosi5Q1yHP6CcGUsZ0JS5H9T+9dzoe27LORO0bQ 3CA8vkiqPyGtE7xr0maP4JpItalb3SDqOKsn9RWwHPIty79ht2LCeUkOehXXtdkRfhpa o7fX/RtkA2/9W5wwHTWC1ZXSAtuy8RV3lSiuUbPV4nYuUed5OwviMPZmqHtWaNhpf7Qp So0A== X-Gm-Message-State: AOAM531enE4Rxnb+088ZRVTg+oJmiuF2gnSGiNgkNl/t07nP64WacS6/ cAM0A9+xSmYjGlQjyaQ+8tAAqw+UMEdC6IOSa/tclI+6 X-Google-Smtp-Source: ABdhPJx4eyvL4t30d3BarUliK0anaYwz3pYg4Gd3Wo201z77Bpb1y0tOYEa3r65HkJECMxUeVqpyA8lsAqPhhzM/c7o= X-Received: by 2002:a1c:9911:: with SMTP id b17mr41268956wme.135.1593966956735; Sun, 05 Jul 2020 09:35:56 -0700 (PDT) In-Reply-To: <831rlqszfw.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=ken.manheimer@gmail.com; helo=mail-wm1-x32a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252703 Archived-At: --0000000000003d710f05a9b45ae5 Content-Type: text/plain; charset="UTF-8" On Sun, Jul 5, 2020 at 12:23 PM Eli Zaretskii wrote: > > From: Ken Manheimer > > Date: Sun, 5 Jul 2020 12:07:47 -0400 > > > > Hi! After a long while since submitting patches (for allout.el and > related stuff) I have a few new ones to > > submit, and am trying to track down canonical guidance on proper > procedures for submitting them. (This > > was spurred by bug@11312, but I have some fixes for independent bugs as > well.) > > [...] > > I'm guessing that I should put the equivalent of what would have been in > the ChangeLog in the commit > > messages, but thought I'd ask here for proper guidance. I welcome > pointers to documents I missed that > > would have made this simpler, as well! > > Yes. Try reading CONTRIBUTE in the repository, I hope it is less > confusing. You can also look at the style of commit log messages with > "git log". > CONTRIBUTE seems to be more current and clear. Together with your confirmation, I feel I have the info I need. (It might make sense to put notes in documents like Submitting Patches deferring to CONTRIBUTE, though that might also require some time and attention to reconcile them...) > Thanks. > Thank you! --0000000000003d710f05a9b45ae5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Jul 5, 2020 at 12:23 PM Eli Zaret= skii <eliz@gnu.org> wrote:
> From: Ken Manheimer <ken.manheimer@gmail.com>
> Date: Sun, 5 Jul 2020 12:07:47 -0400
>
> Hi! After a long while since submitting patches (for allout.el and rel= ated stuff) I have a few new ones to
> submit, and am trying to track down canonical guidance on proper proce= dures for submitting them. (This
> was spurred by bug@11312, but I have some fixes for independent bugs a= s well.)
> [...]
> I'm guessing that I should put the equivalent of wha= t would have been in the ChangeLog in the commit
> messages, but thought I'd ask here for proper guidance. I welcome = pointers to documents I missed that
> would have made this simpler, as well!

Yes.=C2=A0 Try reading CONTRIBUTE in the repository, I hope it is less
confusing.=C2=A0 You can also look at the style of commit log messages with=
"git log".

CONTRIBUTE seems t= o be more current and clear. Together with your=C2=A0confirmation, I feel I= have the info I need. (It might make sense to put notes in documents like = Submitting Patches deferring to CONTRIBUTE, though that might also require = some time and attention to reconcile them...)
=C2=A0
Thanks.

Thank you!=C2=A0
--0000000000003d710f05a9b45ae5--