From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Miguel V. S. Frasson" Newsgroups: gmane.emacs.bugs Subject: bug#34852: 26.1; seq-intersection ignores nil as element Date: Sat, 16 Mar 2019 17:33:10 -0300 Message-ID: References: <87zhpxabn3.fsf@tcd.ie> <87va0lmwlg.fsf@web.de> <87d0mt59pz.fsf@web.de> <875zskrv18.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172143"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Heerdegen , Nicolas Petton , Stefan Monnier , 34852@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 16 21:34:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5G0S-000ies-JF for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Mar 2019 21:34:12 +0100 Original-Received: from localhost ([127.0.0.1]:46102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5G0R-00065o-G2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Mar 2019 16:34:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5G0L-00065i-50 for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 16:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5G0J-0005ZL-8g for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 16:34:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33212) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5G0I-0005Yp-3A for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 16:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5G0H-0008VE-PR for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2019 16:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Miguel V. S. Frasson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2019 20:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34852 X-GNU-PR-Package: emacs Original-Received: via spool by 34852-submit@debbugs.gnu.org id=B34852.155276842732661 (code B ref 34852); Sat, 16 Mar 2019 20:34:01 +0000 Original-Received: (at 34852) by debbugs.gnu.org; 16 Mar 2019 20:33:47 +0000 Original-Received: from localhost ([127.0.0.1]:46756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5G02-0008Uj-Jg for submit@debbugs.gnu.org; Sat, 16 Mar 2019 16:33:46 -0400 Original-Received: from mail-io1-f68.google.com ([209.85.166.68]:35946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h5Fzz-0008UT-Ss for 34852@debbugs.gnu.org; Sat, 16 Mar 2019 16:33:44 -0400 Original-Received: by mail-io1-f68.google.com with SMTP id f6so11180612iop.3 for <34852@debbugs.gnu.org>; Sat, 16 Mar 2019 13:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pAbjpiq1CR+oFAuZ8zkKNQ+6x0YWSD81HzzlERjRIwA=; b=dtivPoHJnMNALOUzrBT0K1fbyDjwORLEzy523y+Uio6n8INGPd4nyPEC70jA+bGG5o p6wmd05DDAgAF/cYEzBnNWBb2ybGhqv6o+TgMB3ahBOT1KozKqNBcoZ5KI6+LoDc4wKM M0uX/0PSwNE/sdCkwXeVI/+QcBmpwqkOnUQ9VGY93Lmz9z6biCoWXoxGamMTQ9tv0fyv fVTDBVQkf8tlQ30oTfoNtS9xzedd6DWUi3QxwzLzFnmgDJmTAkEA97tnwHYU3RqKW/AH 9FgIJePxHX+SPWqir+qh5hvaXYfwJXbPZSda8N5eEzokMvPCscsekE72BqF8pPSLsZj+ QJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pAbjpiq1CR+oFAuZ8zkKNQ+6x0YWSD81HzzlERjRIwA=; b=PZV9DuvQtPtXN8wBuW/RYVO9GaNRL0/bsOt4uY7/ddkYmpks7aOEy4K18fAIVBrPbJ 4vEp2YWQ21TevK3CoGk5L1DgGGZwqeze78d5eJv3QHcEuBlMGeOOxvj7FoFx3zDoMOmd szTuKhjsjnbpwVP5Saj9ucghXEDbYDpn9/a/y2GWpmpcqXA2Kx2zabK7PnBW5Q/R3WXZ FkRCmKTHb0O1DOBFuZLdsULsBklLyimd4zlEWNwfw/NZJXvu0Q0kU3+r4nrJ7QHYjd/Y nvYkX4v72LCgbOukaoJf5Q9Z6O5yQFtujpx2pgDRIu5BDnULH0YoWbMo2gG83d4XGQTv cDew== X-Gm-Message-State: APjAAAWCggi1oT4Ei1h/q3oYaJp7jCSlzh157z93n8WeKWW8h48NJmTK 5b/+yj2UcD+1Ga0ORIKg6UDpmvm0L57lS2HgC1k= X-Google-Smtp-Source: APXvYqyy1p8LbE2vqVQ8UMZt9YLHzXl+oQdcI3HcRouyAOB7GIv7Qp4hu6kpWeMf5Z0QGY0TDP9gpfLiHQ0R35KBvc8= X-Received: by 2002:a5d:8b8c:: with SMTP id p12mr6559527iol.121.1552768417949; Sat, 16 Mar 2019 13:33:37 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156421 Archived-At: Hi Maybe this is the same bug, now with seq-difference (seq-difference '(nil) '(1 nil) #'eq) -> (nil) (In my applications, nil is a frequent element of my lists) Is this fixed by the proposed patches? Cheers. Miguel Em sex, 15 de mar de 2019 =C3=A0s 13:08, Miguel V. S. Frasson escreveu: > > Hi > > I was convinced by the discussions here that changing seq-contains is a b= ad idea. > > I had the false premise that ELT=3Dnil makes seq-contains return nil. > > If I could make a suggestion, it would be include an &optional NOT-FOUND = to be the value returned in case of not finding any element matching TESTFN= . > > Cheers > > Miguel > > Em sex, 15 de mar de 2019 12:56, Basil L. Contovounesios escreveu: >> >> Michael Heerdegen writes: >> >> > "Miguel V. S. Frasson" writes: >> > >> >> In any case, of another implementation for seq-intersection or not, I >> >> think that the solution from Stefan should be implemented anyway >> >> because >> >> >> >> * it makes seq-contains provide a useful return value when ELT=3Dnil,= so >> >> it is a good exception; If ELT=3Dnil, seq-contains currently returns = nil >> >> anyway; >> >> >> >> * it makes seq-contains become a real predicate function, making it >> >> more useful; >> >> >> >> * since seq-contains has been used as predicate before, it is >> >> unpredictable which code uses it out of official repositories, so thi= s >> >> fix potentially fixes other code. >> > >> > BTW, another (alternative) alternative would be to make it return >> > (list ELT). That would be a bit less backward-compatible, but a >> > bit more consistent. >> >> +1, either this or returning a boolean is fine with me. >> >> -- >> Basil --=20 Miguel Vinicius Santini Frasson mvsfrasson@gmail.com