From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 21:13:23 +0300 Message-ID: References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <831rvcgbn2.fsf@gnu.org> <20191016131813.62i6xuwguc7nxyrn@Ergus> <83a7a0egtf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000008f05c05950b0f2c" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="41910"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 20:14:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKnoJ-000AjR-30 for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 20:14:11 +0200 Original-Received: from localhost ([::1]:46740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKnoH-0002Vh-PH for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 14:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKnoB-0002Va-RK for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKnoA-0003NF-Qu for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37680) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKnoA-0003N9-Nz for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKnoA-0007NM-IE for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157124962328319 (code B ref 37774); Wed, 16 Oct 2019 18:14:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 18:13:43 +0000 Original-Received: from localhost ([127.0.0.1]:46501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKnnr-0007Mg-5Y for submit@debbugs.gnu.org; Wed, 16 Oct 2019 14:13:43 -0400 Original-Received: from mail-yw1-f48.google.com ([209.85.161.48]:44833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKnnm-0007MP-Gk for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 14:13:39 -0400 Original-Received: by mail-yw1-f48.google.com with SMTP id m13so8961949ywa.11 for <37774@debbugs.gnu.org>; Wed, 16 Oct 2019 11:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hAWwbA27jvnSNtQhG4Fd/1aJIj3rpCIEk4terjlxHAc=; b=skGTTA8nJTU/DWRMVXbkytARY9sZI0TobTghvsJd7GyI47Svpomw3B0s2FXuIOzu2X zxTtAAvaRsm68BozHwjdr4FQ05JnAOoyEgBKnG+1Cw4i7r5/CKh0LQ6VNaGEcyaVXHmr fnl9Y7W+ae8lVO+7FcA+M203o1rdKGzohSluPXk+2417bL0IsKZXUJNcOKwOXhwkRNpK m+FYm6XuOnbAUNhrAY//z3/M6vJU02I6XuH8pXqMZoMXJQ+XL0kkNBmwDU1Va5/FQYaZ Kbp0g9MErM6EmmIybOlOTBCk6JSLMii6weLlkWYcLkcu0JWz3AX8D0avzVcjeVDKrVe4 zHEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hAWwbA27jvnSNtQhG4Fd/1aJIj3rpCIEk4terjlxHAc=; b=jC3YgXYeAvy3XwsDaSIRENOGMrjUNw7AUcpZYElroJCNNuv+23B2JSK4tAfIY3aukZ u7X6lIETRE5eNAwWvFseIYTctbbCCNBbVbIV0Lkb2Abvq6ym6QqgQ9f01Jt2CVGkLe9c 3UTcDJfnfPqCquWS/W3ykbjCo6TVEyqxcZ5LLquodTT5qxkfjK1YKCUXW/VISBKeHjRW bIpeRHtObesOT78L8cBDzwdy8of4iCZ/KPC/qvUqlZsUSvGiFs3qD3jZBo3qlTEdFEnt fpHDmnPOlpZrA5bMak/DJOiUiN75UUtEgdUkWnnyoiplx+2lgQDyXOcLtJ9ueUwxWdAU nXPw== X-Gm-Message-State: APjAAAW18DN2tndfnX9amP/XHykZDLJnl2IChfEbzZ9ZB5w5P7Zh0tUX mR0ZsnwYd/MvkOWEhlBCD+NXhrpyVjSFv+sU3+w= X-Google-Smtp-Source: APXvYqyurQ8oLAx6ezaaSqJYpyD0VLE0lTOXBP5EUB+bZARRwRcVmU/5zYI/d3uxaNsPkEyZfgcoTkqbICaWv1yyn2w= X-Received: by 2002:a81:994:: with SMTP id 142mr4062552ywj.239.1571249612973; Wed, 16 Oct 2019 11:13:32 -0700 (PDT) In-Reply-To: <83a7a0egtf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169473 Archived-At: --00000000000008f05c05950b0f2c Content-Type: text/plain; charset="UTF-8" > (if (>= emacs-major-version 27) > (defface foo...) ; for Emacs 27 and later > (defface foo...) ; for Emacs 26 and older This results in lots of code duplication. Maybe it's better to: (defface foo...) (when (>= emacs-major-version 27) (set-face-attribute foo... :extend t)) I'm not elisp expert by any means. -- Best regards, Andrey Orst --00000000000008f05c05950b0f2c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> (if (>=3D emacs-major-version 27)=
>=C2=A0 =C2=A0 =C2=A0(defface foo...) ; for Emacs 27 and later
&g= t;=C2=A0 =C2=A0(defface foo...)=C2=A0 =C2=A0; for Emacs 26 and older

This results in lots of code duplication. Maybe it's better to:

(defface foo...)
(when (>=3D emacs-major-version= 27)
=C2=A0 (set-face-attribute foo... :extend t))

<= /div>
I'm not elisp expert by any means.
--
Best regards,
Andrey Orst<= /div>
--00000000000008f05c05950b0f2c--