From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Orst Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 17 Oct 2019 16:40:49 +0300 Message-ID: References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <83k193dhdr.fsf@gnu.org> <83r23bbvdj.fsf@gnu.org> <83pnivbki7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004fbe8b05951b5f7f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1530"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 16:52:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iL78F-0018IZ-8f for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 16:52:03 +0200 Original-Received: from localhost ([::1]:49774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL78D-0006fv-BD for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 10:52:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38760) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL62V-0005gb-2x for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 09:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL62T-0006VO-P1 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 09:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iL62T-0006VI-MH for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 09:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iL62T-0004yn-Ib for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 09:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Orst Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157131969319107 (code B ref 37774); Thu, 17 Oct 2019 13:42:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 17 Oct 2019 13:41:33 +0000 Original-Received: from localhost ([127.0.0.1]:47425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL61w-0004y1-4Z for submit@debbugs.gnu.org; Thu, 17 Oct 2019 09:41:33 -0400 Original-Received: from mail-yw1-f43.google.com ([209.85.161.43]:40614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL61t-0004xn-Ci for 37774@debbugs.gnu.org; Thu, 17 Oct 2019 09:41:26 -0400 Original-Received: by mail-yw1-f43.google.com with SMTP id e205so869657ywc.7 for <37774@debbugs.gnu.org>; Thu, 17 Oct 2019 06:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e8U3nHH9rzDyrXSXpQKJ+CoH6nYUO83ntSpSuBK4Pf8=; b=sPmeLqb5r8TnfEQHUVjzhzT8L72Osqx4rLkK8rduuKeyda5FbSbxmlVrmVbh3aQZNG GYL9w6l+T46nCfJBQmoF7/0ISsDkXSpB50ObcEqzbr6Yah0JmCZJhWuJvX4An0uK8mvD gMP1ahKAXuVjF/i+y4aGnTT3D8EI3nSC/cQJeN6wf3il1I0T8nU1ag8LGjZwSB9lfORb F0f2KkEME4n7Gv50sMtqVMz/c9kWwgyRIdXKwdyJa0xlp7PTs/iwSyp/wtB9kEHvhnhc kSJfNuEQ5Ho+E3slTPOFmdOzph6v0+6GnEzBtxr2uKznKwRHVIf3xIOc/bTYYFZz0GD9 Ggow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e8U3nHH9rzDyrXSXpQKJ+CoH6nYUO83ntSpSuBK4Pf8=; b=IcobqGILFMPLC9dnZcbcwUHqVUg/jI8aL0rlnuCMpeIbIhIt/zbTE8ViCppBDOEnb0 CC4xSWCnRHiF1tzP47ERlalRJ/jhZEnQ7cIhiYl0+KEL1M7H+cT5vzZ8FfbsM6Qhs8pW kpVgTXis31H0Co75SdAFbQ8uMxHOS+XFzK13OAd1SN6I6NEuoQG33dThToUhgE6CFb6n t+aeEvTHsqHrOuEMlLr8fLQskOCCT25YVM4Iv73Ngrj1ObKJVvTkWv84sNrNrX/RyJyJ U3nNDgcbUinPtYWg2SH3uXslrwuntWHFD1mmlOgXKUHY/wgIMlGbdXi1ByUHgytHgtyu Y9nA== X-Gm-Message-State: APjAAAXG35iKFT2cx+WkOoUIn4OgP7XGTn1F1y1iMVgiJxdDOrYujjWN KCcEeam9kcYWb6wvI5zLxDt9F9UZZtsMjUETXhrn7Q9ziCY= X-Google-Smtp-Source: APXvYqw6PM1weUXZ7qaLnEpKBRfdg2KdaE3QNTNUkeZdlwyHqHBLl1zlRnosjPwugbEpJg5fl74xj5kdpkFPbMxvyU4= X-Received: by 2002:a81:54:: with SMTP id 81mr2686310ywa.475.1571319679269; Thu, 17 Oct 2019 06:41:19 -0700 (PDT) In-Reply-To: <83pnivbki7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169579 Archived-At: --0000000000004fbe8b05951b5f7f Content-Type: text/plain; charset="UTF-8" Git diff is an inline diff. It doesn't need changes to be aligned side by side, and doesn't need changes to be linked as in side by side diff tools like, meld, and diff-viewers in Intellij Idea[1], VSCode[2], Sublime Merge[3], Smartgit[4], [1] https://www.oreilly.com/library/view/intellij-idea-essentials/9781784396930/graphics/6930OT_03_44.jpg [2] https://www.meziantou.net/assets/result1.png?v=2c344912 [3] https://edge.alluremedia.com.au/m/l/2018/09/smerge.png [4] https://www.syntevo.com/assets/images/products/smartgit/opener-481720cb.png and even when we looking at inline diff, most GUI tools use extended highlighters, because it is easy to understand: sublime merge: https://i.ytimg.com/vi/ZrdkEBJV660/maxresdefault.jpg Magit: https://magit.vc/screenshots/commit-top.png Consider looking at how magit supposed to look in official screenshots here, and how it looks after the change. https://emacsair.me/2017/09/01/magit-walk-through/ -- Best regards, Andrey Orst --0000000000004fbe8b05951b5f7f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Git diff is an inline diff. It doesn't need changes to= be aligned side by side,
and doesn't need changes to be linked as i= n side by side diff tools like,
meld, and diff-viewers in Intellij Idea[= 1], VSCode[2], Sublime Merge[3], Smartgit[4],

[1] https://www.oreilly.com/library/view/intellij-idea-ess= entials/9781784396930/graphics/6930OT_03_44.jpg
[2] https://www.meziantou= .net/assets/result1.png?v=3D2c344912
[3] https://edge.alluremedia.com.au/m/l= /2018/09/smerge.png
[4] https://www.syntevo.com/assets/= images/products/smartgit/opener-481720cb.png

and even when we lo= oking at inline diff,
most GUI tools use extended highlighters,
because it is easy to understand:


Consider looking at how m= agit supposed to look in official screenshots here,
and how it lo= oks after the change.=C2=A0https://emacsair.me/2017/09/01/magit-walk-through/
--=
Best regards,
Andrey Orst
--0000000000004fbe8b05951b5f7f--