From: Andrey Orst <andreyorst@gmail.com>
To: Andrea Corallo <akrl@sdf.org>
Cc: 40653@debbugs.gnu.org, luknax@sdf.org,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#40653: 28.0.50; (fset 'yes-or-no-p 'y-or-n-p) has no effect in native-comp branch
Date: Thu, 16 Apr 2020 12:58:23 +0300 [thread overview]
Message-ID: <CAAKhXoYMirtinR54C1PLeeVDwfB4p_xEx4s4XH_vNmpE5Ex1Lg@mail.gmail.com> (raw)
In-Reply-To: <xjfd087st2m.fsf@sdf.org>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
>
> The issue is that here we are shadowing with an alias a primitive C
> subr.
>
> Compiling speed 2 the assumption is that these are not redefined or
> advised (the manual warns about doing that). Function calls to C
> primitives at speed 2 are hardcoded for performance reasons in the
> generated code.
We have a customize listing exceptions for that
> `comp-never-optimize-functions'.
>
You should solve the issue adding `yes-or-no-p' to this customize and
> recompiling.
>
Ah I see now. This makes sense, although also makes it harder to
configure.
On the other hand customizing `comp-never-optimize-functions' will solve
>
the issue only for external packages because you likely already have
> compiled the whole Emacs with the default setting...
>
IIUC I may need to modify the source code of the `comp.el` file, because it
gets used when doing `make`?
--
Best regards,
Andrey Orst
[-- Attachment #2: Type: text/html, Size: 2362 bytes --]
next prev parent reply other threads:[~2020-04-16 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 7:59 bug#40653: 28.0.50; (fset 'yes-or-no-p 'y-or-n-p) has no effect in native-comp branch Andrey Orst
2020-04-16 8:18 ` Eli Zaretskii
2020-04-16 8:21 ` Andrey Orst
2020-04-16 8:51 ` Eli Zaretskii
2020-04-16 9:01 ` Andrea Corallo
2020-04-16 9:58 ` Andrey Orst [this message]
2020-04-16 16:49 ` Andrea Corallo
2020-04-16 22:14 ` Sebastian Sturm
2020-04-17 11:26 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAKhXoYMirtinR54C1PLeeVDwfB4p_xEx4s4XH_vNmpE5Ex1Lg@mail.gmail.com \
--to=andreyorst@gmail.com \
--cc=40653@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=luknax@sdf.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.