From: Xue Fuqiao <xfq.free@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 13777@debbugs.gnu.org
Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode
Date: Wed, 8 May 2013 17:39:55 +0800 [thread overview]
Message-ID: <CAAF+z6GT1LC5Lv9F3AHbkP1UN2DVrvD08Aohq5WksWOhKL1V0w@mail.gmail.com> (raw)
In-Reply-To: <nlk3n9di5w.fsf@fencepost.gnu.org>
On Wed, May 8, 2013 at 3:50 PM, Glenn Morris <rgm@gnu.org> wrote:
>> + (defvar edebug-tool-bar-map
>> + (let ((map (make-sparse-keymap)))
>> + (dolist (x '((edebug-set-breakpoint . "gud/break")
>> + (edebug-unset-breakpoint . "gud/remove")
>> + (edebug-go-mode . "gud/go")
>> + (edebug-stop . "gud/stop")
>> + (edebug-continue-mode . "gud/cont")
>> + (edebug-next-mode . "gud/next")
>> + (edebug-step-mode . "gud/step"))
>> + map)
>> + (tool-bar-local-item-from-menu
>> + (car x) (cdr x) map edebug-mode-map))))
>
> Looks alright but:
>
> i) I think this needs to be moved after the easy-menu-define call.
>
> ii) You need to find a way to restore the normal tool-bar after edebug
> exits (for whatever reason).
Agreed.
>> + (defvar debugger-tool-bar-map
>> + (let ((map (make-sparse-keymap)))
>> + (dolist (x '((debugger-continue . "gud/cont")
>> + (debugger-step-through . "gud/step"))
>> + map)
>> + (tool-bar-local-item-from-menu
>> + (car x) (cdr x) map debugger-mode-map))))
>
> Looks ok, but it's a very sparse tool-bar. Is there nothing more that
> can go in it?
There are some candidates, such as `backtrace', `cancel-debug-on-entry'.
But I haven't found suitable icons for them yet.
> It looks a bit silly with just 2 items... Maybe keep some of the
> standard ones?
Sounds like a good compromise.
--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/
next prev parent reply other threads:[~2013-05-08 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 10:49 bug#13777: [patch] Add toolbars for Edebug and debugger-mode Xue Fuqiao
2013-05-08 7:50 ` Glenn Morris
2013-05-08 9:39 ` Xue Fuqiao [this message]
2013-05-08 15:07 ` Stefan Monnier
2016-02-24 5:45 ` Lars Ingebrigtsen
2016-02-25 0:26 ` Xue Fuqiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAF+z6GT1LC5Lv9F3AHbkP1UN2DVrvD08Aohq5WksWOhKL1V0w@mail.gmail.com \
--to=xfq.free@gmail.com \
--cc=13777@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.