all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Xue Fuqiao <xfq.free@gmail.com>
To: 14995@debbugs.gnu.org
Subject: bug#14995: [PATCH] vc-do-command ignores symbolic links
Date: Wed, 31 Jul 2013 18:53:42 +0800	[thread overview]
Message-ID: <CAAF+z6GHFY2UtCDuv96Xea+t5LgN5zty=mtwBzRAe4vDT4JABg@mail.gmail.com> (raw)

tags patch

This small patch fixes a bug in vc-do-command:

=== modified file 'lisp/vc/vc-dispatcher.el'
--- lisp/vc/vc-dispatcher.el    2013-06-15 02:50:47 +0000
+++ lisp/vc/vc-dispatcher.el    2013-07-31 10:49:27 +0000
@@ -275,11 +275,8 @@
 that is inserted into the command line before the filename.
 Return the return value of the slave command in the synchronous
 case, and the process object in the asynchronous case."
-  ;; FIXME: file-relative-name can return a bogus result because
-  ;; it doesn't look at the actual file-system to see if symlinks
-  ;; come into play.
   (let* ((files
-      (mapcar (lambda (f) (file-relative-name (expand-file-name f)))
+      (mapcar (lambda (f) (file-relative-name (file-truename
(expand-file-name f))))
           (if (listp file-or-list) file-or-list (list file-or-list))))
      (full-command
       ;; What we're doing here is preparing a version of the command


-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/





             reply	other threads:[~2013-07-31 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 10:53 Xue Fuqiao [this message]
2013-07-31 14:13 ` bug#14995: [PATCH] vc-do-command ignores symbolic links Stefan Monnier
2013-07-31 22:38   ` Xue Fuqiao
2014-02-06  1:00     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAF+z6GHFY2UtCDuv96Xea+t5LgN5zty=mtwBzRAe4vDT4JABg@mail.gmail.com' \
    --to=xfq.free@gmail.com \
    --cc=14995@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.