From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Xue Fuqiao Newsgroups: gmane.emacs.devel Subject: Re: Hello / First contribution / Major Mode menu entries Date: Wed, 2 Oct 2013 22:16:22 +0800 Message-ID: References: <20131002052755.GA6413@jo.hnanthony.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1380723391 6246 80.91.229.3 (2 Oct 2013 14:16:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Oct 2013 14:16:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: John Anthony Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 16:16:36 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRNEC-0003nT-CU for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2013 16:16:36 +0200 Original-Received: from localhost ([::1]:36321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRNEB-0007RW-SJ for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2013 10:16:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRNE4-0007RN-G0 for emacs-devel@gnu.org; Wed, 02 Oct 2013 10:16:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRNDz-0005YE-N7 for emacs-devel@gnu.org; Wed, 02 Oct 2013 10:16:28 -0400 Original-Received: from mail-ie0-x234.google.com ([2607:f8b0:4001:c03::234]:61815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRNDz-0005WP-Ie for emacs-devel@gnu.org; Wed, 02 Oct 2013 10:16:23 -0400 Original-Received: by mail-ie0-f180.google.com with SMTP id u16so1924018iet.11 for ; Wed, 02 Oct 2013 07:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=oCYTngrwy2De0WxZRXMR3NrgdkNbgPtblUw0zyy9z5A=; b=Mj4vADdDUFNY9yD2iTCdwo57GEwfWdjeW7c2suLN9ozxieUbrmfIIUN7Bpf7VCFQAs dfX1tjmjZLOZn7vdGYXcQiJL3+j2oN56cPlGpzIrm7+dTDYb0mTjn+FyfltemhWif7JO xBBCXkbz4pG4T/dwUcbgEYXCM9fv6IP4NCmBi3LYiXdBZ2c9htJP9W6bGxMxcQ6QqxbH 6QzmQwdSJVm/qd4ly92CQiU9ThrO3HtHhQgzdxxrF1qf4H+bEj6/Z7PiG4Ibako6sKRf KQ6j90GKAfc1hKOUMKHv1/4QdWpggf8X2hakPy2m4dVLrvkJIt12//gN0wAnTGcKYBQl FQmg== X-Received: by 10.42.82.196 with SMTP id e4mr1113156icl.58.1380723382551; Wed, 02 Oct 2013 07:16:22 -0700 (PDT) Original-Received: by 10.42.133.72 with HTTP; Wed, 2 Oct 2013 07:16:22 -0700 (PDT) In-Reply-To: <20131002052755.GA6413@jo.hnanthony.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163808 Archived-At: On Wed, Oct 2, 2013 at 1:27 PM, John Anthony wrote: > Hey there, guys. > > I'm interested in taking care of a bunch of the little TODO items in > etc/TODO. I've read etc/CONTRIBUTE and understand that there are > special considerations when contributing to emacs and other FSF > projects. I thought I'd start by handling the major mode menu items > mentioned on line 65 of etc/TODO. I thought I'd get some feedback > before I steam in and do a bunch: > > > diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el > index d9ff04c..367a84a 100644 > --- a/lisp/textmodes/text-mode.el > +++ b/lisp/textmodes/text-mode.el > @@ -192,4 +192,22 @@ The argument NLINES says how many lines to center." > (setq nlines (1+ nlines)) > (forward-line -1))))) > > +(easy-menu-define text-mode-menu text-mode-map > + "Menu for Text mode." > + '("Text Mode" > + ["Center Line" center-line > + :help "Center the current line" > + :active t] > + ["Center Lines" (lambda (n) > + (interactive "nNumber of lines to indent: ") > + (center-line n)) > + :help "Center several lines" > + :active t] > + ["Center Paragraph" center-paragraph > + :help "Center the current paragraph" > + :active t] > + ["Center Region" center-region > + :help "Center the selected region" > + :active (region-active-p)])) > ;;; text-mode.el ends here > > > When I post such patches to bug-gnu-emacs.org would I be better off > submitting a diff generated by bzr? Using =E2=80=98diff -c=E2=80=99 to make your diffs is recommended. See (in= fo "(emacs) Sending Patches"). > This is my first message to emacs-devel and I'm vaguely aware of the > fact that I may not be doing things correctly. I'd very much > appreciate any help/advice I could get. Thanks for wanting to contribute, welcome, and do not hesitate to ask any further question, we are here to help! --=20 Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/