bug#15341: 24.3.50; Wrong face in diff-mode

bug#15341: 24.3.50; Wrong face in diff-mode

[Xue Fuqiao]

When I was trying to read this patch is diff-mode:
http://git.savannah.gnu.org/cgit/emacs.git/commit/etc/tutorials/TUTORIAL?id=2d0ab7fceb093acaead8d964ffaf8230098507c9

I found that the ">> Move the cursor to this line and type C-u 0 C-l"
line is displayed as the ‘diff-added’ face, but it shouldn't.  It should
use the ‘diff-context’ face.




In GNU Emacs 24.3.50.1 (x86_64-apple-darwin12.4.0, NS apple-appkit-1187.39)
 of 2013-09-07 on xfq.local
Bzr revision: 114163 eggert@cs.ucla.edu-20130907002056-0jom28xr5402rpm9
Windowing system distributor `Apple', version 10.3.1187
Configured using:
 `configure --with-ns --enable-checking --disable-silent-rules'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<escape> x r e - e m - b u <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process ns multi-tty
emacs)


-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

bug#15341: 24.3.50; Wrong face in diff-mode

[Stefan Monnier]

> When I was trying to read this patch is diff-mode:
> http://git.savannah.gnu.org/cgit/emacs.git/commit/etc/tutorials/TUTORIAL?id=2d0ab7fceb093acaead8d964ffaf8230098507c9

This is an HTML page.  How did you get it into a diff-mode buffer?

> I found that the ">> Move the cursor to this line and type C-u 0 C-l"
> line is displayed as the ‘diff-added’ face, but it shouldn't.

I strongly suspect that the space before the ">>" got dropped along the
way to the diff-mode buffer, resulting in an invalid patch, which would
explain and justify the mis-highlighting.


        Stefan

bug#15341: 24.3.50; Wrong face in diff-mode

[Xue Fuqiao]

Yes, the space before the ">>" got dropped along the way to the
diff-mode buffer.  Sorry for the noise.

-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/