From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Fran=C3=A7ois_?= =?UTF-8?Q?F=C3=A9votte?= Newsgroups: gmane.emacs.bugs Subject: bug#15539: [PATCH] Setting user-emacs-directory Date: Wed, 1 Apr 2015 19:16:36 +0200 Message-ID: References: <87384jhn9u.fsf@gmail.com> <87d23npzez.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1427908642 23507 80.91.229.3 (1 Apr 2015 17:17:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 1 Apr 2015 17:17:22 +0000 (UTC) Cc: 15539@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 01 19:17:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YdMGO-0000B8-8A for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Apr 2015 19:17:12 +0200 Original-Received: from localhost ([::1]:54219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdMGN-0002X0-GX for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Apr 2015 13:17:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdMGK-0002Wq-4D for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 13:17:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YdMGF-00056R-3D for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 13:17:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YdMGF-000569-0x for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 13:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YdMGE-0005qb-B5 for bug-gnu-emacs@gnu.org; Wed, 01 Apr 2015 13:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Fran=C3=A7ois_?= =?UTF-8?Q?F=C3=A9votte?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Apr 2015 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15539-submit@debbugs.gnu.org id=B15539.142790860322441 (code B ref 15539); Wed, 01 Apr 2015 17:17:02 +0000 Original-Received: (at 15539) by debbugs.gnu.org; 1 Apr 2015 17:16:43 +0000 Original-Received: from localhost ([127.0.0.1]:42639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdMFu-0005pt-Om for submit@debbugs.gnu.org; Wed, 01 Apr 2015 13:16:42 -0400 Original-Received: from mail-qc0-f178.google.com ([209.85.216.178]:34386) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YdMFt-0005pg-KX for 15539@debbugs.gnu.org; Wed, 01 Apr 2015 13:16:42 -0400 Original-Received: by qcay5 with SMTP id y5so46734026qca.1 for <15539@debbugs.gnu.org>; Wed, 01 Apr 2015 10:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=ybSFAW3ruiDyh8RQlt3M7ssKX0aXKK9ak9pN2rJ9KJ8=; b=C8ONqdrAVfk7ojYb56MiFRJzh9huoReyZ6utNd9Lugy1dzV2tUmonYGmLFnPgoLSxh civhiIiVF10ivhk1TN8899B8HNY4DKByKhLof7r5LdU/QbqtXv3MCQz3ofsRNAmLCNpX k6Shb5y6l45AJfow6IZxJmJ53jQEcqpZEuV1ub39w5KyQhXLkYKI+UmcddAqoGa0yPp1 c0qPkxE6CAv2ibdODAcfWnnUd/Fbxpb3jTslAPD0jnfnIzmJPL6qFBPBOUFZn/GuAYD6 mcY4CycewEXMkpSF0BXs0P6JO0IhOnY5C2XnrJdFM3vrjywUR72X9B91sqwczCOu/kVf bKZw== X-Received: by 10.55.49.147 with SMTP id x141mr5672606qkx.23.1427908596094; Wed, 01 Apr 2015 10:16:36 -0700 (PDT) Original-Received: by 10.229.14.72 with HTTP; Wed, 1 Apr 2015 10:16:36 -0700 (PDT) In-Reply-To: <87d23npzez.fsf@gmail.com> X-Google-Sender-Auth: ad6E-xVLjw1EW8pYHxx9LI2Q8J0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101121 Archived-At: Thanks for testing On Wed, Apr 1, 2015 at 6:48 PM, Oleh Krehel wrote: > Just one question: why is `getenv' called twice? with the currently implemented logic, the environment variable has two different impacts: (1) it sets the `user-emacs-directory' variable, and (2) it changes the logic used to determine the init file. There is currently no `let' form encompassing the whole `command-line' function, so I had to either 1- add one (which might be the most correct implementation, but generates a very large patch for mostly unchanged lines) 2- define a global variable (which seems unnecessary), or 3- call `getenv' multiple times. I chose the latter, but am perfectly open to rewriting the implementation if you feel it would be better. Fran=C3=A7ois