From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jaesup Kwak Newsgroups: gmane.emacs.bugs Subject: bug#29565: [PATCH] Support xwidget webkit for macOS X Date: Tue, 5 Dec 2017 15:01:45 +0900 Message-ID: References: <20171204205943.GA38879@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045e9fb8db283b055f91918b" X-Trace: blaine.gmane.org 1512454504 13096 195.159.176.226 (5 Dec 2017 06:15:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Dec 2017 06:15:04 +0000 (UTC) Cc: 29565@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 05 07:14:59 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM6VM-0002zw-N7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Dec 2017 07:14:56 +0100 Original-Received: from localhost ([::1]:46724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM6VT-0000ja-Vk for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Dec 2017 01:15:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM6Ix-0004Tz-K0 for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 01:02:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM6It-0006TY-Du for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 01:02:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM6It-0006TT-6E for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 01:02:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eM6Is-0008Es-Oy for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 01:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jaesup Kwak Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Dec 2017 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29565-submit@debbugs.gnu.org id=B29565.151245371431655 (code B ref 29565); Tue, 05 Dec 2017 06:02:02 +0000 Original-Received: (at 29565) by debbugs.gnu.org; 5 Dec 2017 06:01:54 +0000 Original-Received: from localhost ([127.0.0.1]:46273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM6Ik-0008EV-Gl for submit@debbugs.gnu.org; Tue, 05 Dec 2017 01:01:54 -0500 Original-Received: from mail-wr0-f173.google.com ([209.85.128.173]:42745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM6Ih-0008EG-Cr for 29565@debbugs.gnu.org; Tue, 05 Dec 2017 01:01:53 -0500 Original-Received: by mail-wr0-f173.google.com with SMTP id s66so19687296wrc.9 for <29565@debbugs.gnu.org>; Mon, 04 Dec 2017 22:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VOl8IG98DykNpGDdmMhLByimsgYO74EUsYTx2xDBdME=; b=WaOtsMtlzNEM1tBzUEHPqJ/1tfdmlvkiPvXkXkkbRJn6uOHVX9eLGrZ/kcgs4/KcZY uqGQRX8HMmvj5IjcxSmWy90MfRUEvc8LWQ1ncneiXtVJGtIYae3OGadxXommIWTh6mCt W4+Rj6z1/3eMvoLwMAyu5x4cKGRY4K/JZwGWeC/f7s0DzDHqvd7gL13kJsTtK9LDO4IT Qhw1TLEvBXDi+/2QuOJMbse9wFOBJue1AnV2HfsMsgFkOZqqbJJCpSfdWaLGeDsbdcf/ FrBLzAQCESNK5waskUVkxN6YvH4S3Jvd9ek2ct64dmjK6yO7GyZ1U5l3zum+ZoslMjQE e0HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VOl8IG98DykNpGDdmMhLByimsgYO74EUsYTx2xDBdME=; b=kCxRWIhqZw9ooPyOJfe75JnjWQlyfGOw76oPXm21DrZVVdBSQRy9GuOhUrqh5Qi3sB aW+xcavo72LNHo+jZA+aZOkoyQCdRZ6C0LYDLwlOjaky7VVdtD2PqD6aSu7xd/j0QnIJ 3eIn7CEktAWVA7kGQSQXOogqbOeJp31nMloliql6bGe93A3VVzjID9GaxN1CD+V+yGyg bcA8SFeSHeQ2N0Nb/LHTSHKAycDbNLxj4Hq6VnfUlB4EhOITorrI6Gyjspiw+sobGHrk FyIVz7HTjGTO9DAfFGt0lIaNPvYNJuhLjRA6/iYJqgXOjo4JRtQvypaadMMnsJCHsgzk s74A== X-Gm-Message-State: AJaThX6S9+d7qAy8wTut2qdRJ6pEUs/inf0TZEbkfEDdZRFAhsNDQwri Sb2snbY5getoeWB0zNQLoyKgaRGSA3/6sqcaJLo= X-Google-Smtp-Source: AGs4zMa2xJzDN7CR1zMIJlcVvYOBBMTHRIC0S1eP7CtZvkQjPD9xStw2i3u3gpUiboudXR/v+hF6dLx36F4a0YvzH8U= X-Received: by 10.223.139.8 with SMTP id n8mr15235221wra.225.1512453705507; Mon, 04 Dec 2017 22:01:45 -0800 (PST) Original-Received: by 10.28.227.67 with HTTP; Mon, 4 Dec 2017 22:01:45 -0800 (PST) In-Reply-To: <20171204205943.GA38879@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140717 Archived-At: --f403045e9fb8db283b055f91918b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 5, 2017 at 5:59 AM, Alan Third wrote: > > In configure.ac you=E2=80=99re doing > > elif test "$window_system" =3D "nextstep"; then > > I think instead of that you should be doing > > elif test "${NS_IMPL_COCOA}" =3D "yes"; then > > as nextstep covers GNUstep, but it doesn=E2=80=99t have a webkit > implementation (yet). > > There might be other places where NS_IMPL_COCOA is more appropriate > than HAVE_NS, but it builds fine against GNUstep with xwidgets off, so > it=E2=80=99s not too important. > Agree. I fixed to use "${NS_IMPL_COCOA}" in configura.ac and #ifdef NS_IMPL_COCOA in implementation source files. I am testing the fixes. It looks good to me also. > I notice you=E2=80=99re adding .DS_Store to .gitignore, which is a good i= dea, > but I don=E2=80=99t think it should be done in this patch. It seems a lit= tle > off=E2=80=90topic. Okay, I will remove it from .gitignore. I=E2=80=99m also a little unsure about this > > > NSAppTransportSecurity > > NSAllowsArbitraryLoads > > > > The comment says =E2=80=98uncomment=E2=80=99, but it *is* uncommented. Am= I > misunderstanding? > You are right, the comment is outdated and I will fix it. > (Also I think there should be two spaces at the end of comments.) > I was curious about the two spaces ending comments. It is clear now thanks to you. I will fix this also. > > I think we=E2=80=99ll want to add NSTRACE lines in each function, but per= haps > we should create a new category for XWidgets. I put off this item at this time, there will be chance to do this later. I will soon post a patch accompanying above changes. Thanks for your valuable comments. --f403045e9fb8db283b055f91918b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On T= ue, Dec 5, 2017 at 5:59 AM, Alan Third <alan@idiocy.org> wrote= :

In con= figure.ac you=E2=80=99re doing

=C2=A0 =C2=A0 elif test "$window_system" =3D "nextstep"= ; then

I think instead of that you should be doing

=C2=A0 =C2=A0 elif test "${NS_IMPL_COCOA}" =3D "yes"; t= hen

as nextstep covers GNUstep, but it doesn=E2=80=99t have a webkit
implementation (yet).

There might be other places where NS_IMPL_COCOA is more appropriate
than HAVE_NS, but it builds fine against GNUstep with xwidgets off, so
it=E2=80=99s not too important.

Agree. = I fixed to use "${NS_IMPL_COCOA}" in configura.ac
and #ifdef NS_IMPL_COCOA in implementation s= ource files.
I am testing the fixes. It looks good to me also.
=C2=A0
I notice you=E2=80=99re adding .DS_Store to .gitignore, which is a good ide= a,
but I don=E2=80=99t think it should be done in this patch. It seems a littl= e
off=E2=80=90topic.

Okay, I will remove it f= rom .gitignore.=C2=A0

I=E2=80=99m also a little unsure about this

=C2=A0 =C2=A0 <!-- FIXME: Uncomment for xwidget webkit to browse remote = url,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0but this set no restriction at all.=C2=A0= Consult apple's documentation
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for detail information about `NSApplicati= onDefinedMask'. -->
=C2=A0 =C2=A0 <key>NSAppTransportSecurity</key>
=C2=A0 =C2=A0 <dict>
=C2=A0 =C2=A0 =C2=A0 <key>NSAllowsArbitraryLoads</key>
=C2=A0 =C2=A0 =C2=A0 <true/>
=C2=A0 =C2=A0 </dict>

The comment says =E2=80=98uncomment=E2=80=99, but it *is* uncommented. Am I=
misunderstanding?

You are right, the co= mment is outdated and I will fix it.
=C2=A0
(Also I think there should be two spaces at the end of comments.)

I was curious about the two spaces ending commen= ts.=C2=A0 It is clear now thanks to you.
I will fix this also.
=C2=A0

I think we=E2=80=99ll want to add NSTRACE lines in each function, but perha= ps
we should create a new category for XWidgets.

I put off this item at this time, there will be chance to do this later.=

I will soon post a patch accompanying above chang= es.

Thanks for your valuable comments.
=
--f403045e9fb8db283b055f91918b--