From: Jaesup Kwak <veshboo@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: 29565@debbugs.gnu.org
Subject: bug#29565: [PATCH] Support xwidget webkit for macOS X
Date: Tue, 5 Dec 2017 15:01:45 +0900 [thread overview]
Message-ID: <CAADX8xLuN56bOnA9U7JaRT=oKJJXOEGUneJLnfR_Anh4KRaVaw@mail.gmail.com> (raw)
In-Reply-To: <20171204205943.GA38879@breton.holly.idiocy.org>
[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]
On Tue, Dec 5, 2017 at 5:59 AM, Alan Third <alan@idiocy.org> wrote:
>
> In configure.ac you’re doing
>
> elif test "$window_system" = "nextstep"; then
>
> I think instead of that you should be doing
>
> elif test "${NS_IMPL_COCOA}" = "yes"; then
>
> as nextstep covers GNUstep, but it doesn’t have a webkit
> implementation (yet).
>
> There might be other places where NS_IMPL_COCOA is more appropriate
> than HAVE_NS, but it builds fine against GNUstep with xwidgets off, so
> it’s not too important.
>
Agree. I fixed to use "${NS_IMPL_COCOA}" in configura.ac
and #ifdef NS_IMPL_COCOA in implementation source files.
I am testing the fixes. It looks good to me also.
> I notice you’re adding .DS_Store to .gitignore, which is a good idea,
> but I don’t think it should be done in this patch. It seems a little
> off‐topic.
Okay, I will remove it from .gitignore.
I’m also a little unsure about this
>
> <!-- FIXME: Uncomment for xwidget webkit to browse remote url,
> but this set no restriction at all. Consult apple's documentation
> for detail information about `NSApplicationDefinedMask'. -->
> <key>NSAppTransportSecurity</key>
> <dict>
> <key>NSAllowsArbitraryLoads</key>
> <true/>
> </dict>
>
> The comment says ‘uncomment’, but it *is* uncommented. Am I
> misunderstanding?
>
You are right, the comment is outdated and I will fix it.
> (Also I think there should be two spaces at the end of comments.)
>
I was curious about the two spaces ending comments. It is clear now thanks
to you.
I will fix this also.
>
> I think we’ll want to add NSTRACE lines in each function, but perhaps
> we should create a new category for XWidgets.
I put off this item at this time, there will be chance to do this later.
I will soon post a patch accompanying above changes.
Thanks for your valuable comments.
[-- Attachment #2: Type: text/html, Size: 3589 bytes --]
next prev parent reply other threads:[~2017-12-05 6:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 16:44 bug#29565: [PATCH] Support xwidget webkit for macOS X Jaesup Kwak
2017-12-04 20:59 ` Alan Third
2017-12-05 6:01 ` Jaesup Kwak [this message]
2017-12-05 7:55 ` Jaesup Kwak
2017-12-05 20:00 ` Alan Third
2017-12-06 5:59 ` Jaesup Kwak
2017-12-06 6:20 ` Jaesup Kwak
2017-12-13 11:15 ` Jaesup Kwak
2017-12-13 11:27 ` Jaesup Kwak
2017-12-13 16:13 ` Jaesup Kwak
2017-12-15 2:01 ` Jaesup Kwak
2017-12-15 2:27 ` Jaesup Kwak
2017-12-15 16:06 ` Jaesup Kwak
2017-12-20 2:39 ` bug#29565: [PATCH] Fix compile failure for GTK xwidget (Bug#29565) Jaesup Kwak
2017-12-20 8:25 ` bug#29565: [PATCH] Enable plugins for ns xwidget webkit (Bug#29565) Jaesup Kwak
2017-12-21 4:12 ` bug#29565: [PATCH] Support file download and upload (Bug#29565) Jaesup Kwak
2018-03-30 11:48 ` bug#29565: [PATCH] Support xwidget webkit for macOS X Alan Third
2018-03-30 12:19 ` Jaesup Kwak
2019-09-28 23:52 ` Stefan Kangas
2020-08-10 13:55 ` Lars Ingebrigtsen
2020-08-10 19:06 ` Alan Third
2020-08-11 11:04 ` Lars Ingebrigtsen
2020-08-11 15:22 ` Eli Zaretskii
2020-08-11 16:26 ` Lars Ingebrigtsen
2020-08-11 18:28 ` Eli Zaretskii
2020-08-11 19:26 ` Lars Ingebrigtsen
2020-08-11 19:33 ` Eli Zaretskii
2020-08-12 10:44 ` Lars Ingebrigtsen
2020-08-11 19:56 ` Alan Third
2020-08-11 19:58 ` Lars Ingebrigtsen
2020-08-11 20:18 ` Alan Third
2020-08-11 20:29 ` Lars Ingebrigtsen
2020-08-11 20:35 ` Alan Third
2020-08-11 20:50 ` Lars Ingebrigtsen
2020-08-12 3:46 ` Unknown
2020-08-12 10:05 ` Lars Ingebrigtsen
2020-08-12 16:34 ` Alan Third
2020-08-12 2:26 ` Richard Stallman
2020-08-12 4:13 ` Eli Zaretskii
2020-08-12 4:27 ` Eli Zaretskii
2020-08-13 3:43 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADX8xLuN56bOnA9U7JaRT=oKJJXOEGUneJLnfR_Anh4KRaVaw@mail.gmail.com' \
--to=veshboo@gmail.com \
--cc=29565@debbugs.gnu.org \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.