From: Jaesup Kwak <veshboo@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix unnecessary xwidget_view creation
Date: Thu, 16 Nov 2017 12:40:31 +0900 [thread overview]
Message-ID: <CAADX8xJ+MpExA8JzRPEC7aVBwatnsO7gzv=VL5FT_+NotWDKgQ@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 94 bytes --]
The patch file attached in the original post appears as a binary file.
Reposting with ".txt".
[-- Attachment #1.2: Type: text/html, Size: 135 bytes --]
[-- Attachment #2: 0001-FIX-UNNECESSARY-XWIDGET-VIEW-CREATION.txt --]
[-- Type: text/plain, Size: 1506 bytes --]
From cbd894121367cda2bd412bffec5412540fe6c7f9 Mon Sep 17 00:00:00 2001
From: Jaesup Kwak <veshboo@gmail.com>
Date: Mon, 6 Nov 2017 03:47:11 +0900
Subject: [PATCH] Fix unnecessary xwidget_view creations
* src/xwidget.c (x_draw_xwidget_glyph_string): Don't create new
xwidget view if we have one already.
Copyright-paperwork-exempt: yes
---
src/xwidget.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/xwidget.c b/src/xwidget.c
index a0c9e03477..fb776fb189 100644
--- a/src/xwidget.c
+++ b/src/xwidget.c
@@ -585,22 +585,20 @@ x_draw_xwidget_glyph_string (struct glyph_string *s)
xwidget on screen. Moving and clipping is done here. Also view
initialization. */
struct xwidget *xww = s->xwidget;
- struct xwidget_view *xv;
+ struct xwidget_view *xv = xwidget_view_lookup (xww, s->w);
int clip_right;
int clip_bottom;
int clip_top;
int clip_left;
- /* FIXME: The result of this call is discarded.
- What if the lookup fails? */
- xwidget_view_lookup (xww, s->w);
-
int x = s->x;
int y = s->y + (s->height / 2) - (xww->height / 2);
/* Do initialization here in the display loop because there is no
other time to know things like window placement etc. */
- xv = xwidget_init_view (xww, s, x, y);
+ /* Do not create new one if we have found one to use. */
+ if (!xv)
+ xv = xwidget_init_view (xww, s, x, y);
int text_area_x, text_area_y, text_area_width, text_area_height;
--
2.13.6 (Apple Git-96)
next reply other threads:[~2017-11-16 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 3:40 Jaesup Kwak [this message]
2017-11-24 9:35 ` [PATCH] Fix unnecessary xwidget_view creation Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2017-11-05 19:56 Jaesup Kwak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADX8xJ+MpExA8JzRPEC7aVBwatnsO7gzv=VL5FT_+NotWDKgQ@mail.gmail.com' \
--to=veshboo@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.