all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Matt Micheletti <mattdmicheletti@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [BUG] org-add-planning-info does not respect org-scheduled-string or org-deadline-string
Date: Thu, 25 Nov 2021 20:28:55 -0500	[thread overview]
Message-ID: <CAAC2O3ee_v30Fu-mDdBww6FFjj==qGJ52Etvd-6QDqVxdDshew@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

Hello,

The following lines in `org-add-planning-info` (Lines 10844 & 10845 as
of commit
cc3df3a
<https://github.com/bzg/org-mode/commit/cc3df3af2ae9081c1ba08dd80e068b60ad76dda3>)
do not respect the usage of the org-scheduled-string or org-deadline-string
values when prompting the user to enter a schedule or deadline timestamp
leading to confusion amongst the inconsistent UI/UX when those strings are
changed (as Org Mode permits).

Source/Attribution Credits: Lines 10844 ~ 10845
<https://github.com/bzg/org-mode/blob/main/lisp/org.el#L10844>
```
(defun org-add-planning-info (what &optional time &rest remove)
;; Omitted for brevity...
;; If necessary, get the time from the user
(or time (org-read-date nil 'to-time nil
(cl-case what
(deadline "DEADLINE")
(scheduled "SCHEDULED")
(otherwise nil))
default-time default-input)))))
```

Recommend changing to

 ```
(defun org-add-planning-info (what &optional time &rest remove)
;; Omitted for brevity...
;; If necessary, get the time from the user
(or time (org-read-date nil 'to-time nil
(cl-case what
(deadline org-deadline-string)
(scheduled org-scheduled-string)
(otherwise nil))
default-time default-input)))))
```

Thanks,
Matt M.

[-- Attachment #2: Type: text/html, Size: 1432 bytes --]

             reply	other threads:[~2021-11-26 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  1:28 Matt Micheletti [this message]
2021-11-26 10:42 ` [BUG] org-add-planning-info does not respect org-scheduled-string or org-deadline-string Ihor Radchenko
2021-11-27  2:13   ` Matt Micheletti
2021-11-27  3:01     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAC2O3ee_v30Fu-mDdBww6FFjj==qGJ52Etvd-6QDqVxdDshew@mail.gmail.com' \
    --to=mattdmicheletti@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.