From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?6Lev5a6i?= Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Date: Tue, 31 Jan 2023 23:12:43 +0800 Message-ID: References: <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org> <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009710fb05f390c5ad" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28830"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 31 16:14:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMsLC-0007Kn-CS for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Jan 2023 16:14:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMsK6-0003r5-6e; Tue, 31 Jan 2023 10:13:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMsK2-0003kj-Qt for emacs-devel@gnu.org; Tue, 31 Jan 2023 10:13:23 -0500 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMsK1-0004LT-0Z for emacs-devel@gnu.org; Tue, 31 Jan 2023 10:13:22 -0500 Original-Received: by mail-oi1-x234.google.com with SMTP id o66so13061767oia.6 for ; Tue, 31 Jan 2023 07:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Q+lpqjXyuXo5P4wJ1adyCe9rehakLc8ge/Og/EUrDEU=; b=dQoRxIHVYo3WbEq+m8WQXFzJStdlG1mJsEFqoiWtPtqE4zDYuuvqJqcROmALAAwExo Tqp3xL9MGqYbyczz51EdfCqV/+bvTGCVok65DHFfAmpkXr3eP4aO1n/dkjM1xGhQixSE Ug9tGWXSmubo6MRwMyfahDS+wJZuJ2X5Cn1/LFlX42r4mVJxT/zFc2nJuhppyMqB4uSk d/5rPMsRzYV2cB7JnONZ81cKClR1qHRELvmxb2D7awoD+mNluwKrolVYg8B9hjWtS4Se zCp6HYYmHVMNZatObjYMW1drqjReC1eGAMUpa7O8EYCMkbkcM2vYM2kBMIc2be0xDVGc 8sHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q+lpqjXyuXo5P4wJ1adyCe9rehakLc8ge/Og/EUrDEU=; b=AL4KWZkR5K8RZvAWEbZSVI6ELHoF9FLbdgqZshPFdIBj1kHVEyvWjpAICJ4R/WLezj XNn1lDSdYqZDiSZEauPcOVkv/Nsvk//qgTNzNRo5PKkkjHIhTgi/bLaCajw3kNh8jvgQ 8Qdq2Tl80aMmjCFuamj+Rc4JAHSX1pSM+LkqNisxGjuPpFrXWbiR73IHRMPNCjfsJYwL ahOf4h21EzrY/9hLa0moZNh/IPNSMuJ/V/2dIecouB2WwzP2BXlFGOjG+g9JQ8i99fHN a9U0OLCGMbTX2JxHnj8GlEL6O6gdc9QnJA06hLRycWv4J81JtUB0xqS1BxIZu56rQWgd AXjQ== X-Gm-Message-State: AO0yUKUUrHfyJN2LcovGsyh25iEq3rEFnD2fUdIECxl/Z3IvQZj5bjw9 2mRVqX05vw0fyyq21Qkl+vA2UwyeLrQ5P4GXCmU= X-Google-Smtp-Source: AK7set96rOTBgcnRr+t3uBFeACDHD01U46mYApc+tCaJshT4DA6Y4h1qs0JCA37fxMaQl9xr8aEwSDQ77R5JhQUj/ic= X-Received: by 2002:a05:6808:5c6:b0:375:41bc:b5ff with SMTP id d6-20020a05680805c600b0037541bcb5ffmr1322800oij.143.1675177999404; Tue, 31 Jan 2023 07:13:19 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=luke.yx.lee@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302836 Archived-At: --0000000000009710fb05f390c5ad Content-Type: text/plain; charset="UTF-8" > The arg to `fboundp` is a symbol not a function (e.g. it can't > be a (lambda ...) for example) That's a good point, modification reverted. > (<= 27 emacs-major-version) Nice, modified likewise. > Doesn't (scroll-bar-mode -1) do that already? You're right, corrected as well as some others. Thanks! On Mon, 30 Jan 2023 at 10:58, Stefan Monnier wrote: > > branch: externals/brief > > commit 362d6296717af611be20cb56592d495c01ea7a00 > > Author: Luke Lee > > Commit: Luke Lee > > Please try and use a valid email as commit identifier. > > > @@ -457,8 +461,9 @@ > > ;; backward compatibility issues. > > ;;(require 'replace) > > > > -(defconst brief-version "5.87" > > - "The version of this Brief emulator.") > > +;;;###autoload > > +(defconst brief-version "5.88.22" > > + "Current version of this Brief editor mode/emulator.") > > Why autoload? > > > - (not (fboundp 'save-mark-and-excursion))) > > + (not (fboundp #'save-mark-and-excursion))) > > The arg to `fboundp` is a symbol not a function (e.g. it can't be > a (lambda ...) for example), so I think #' is ill-advised. > It works fine, in practice, so it's somewhat of a philosophical issue. > > > + (when (and (version<= "27.0" emacs-version) > > I understand efficiency is not a major issue here, but > > (<= 27 emacs-major-version) > > works just as well :-) > > > - (scroll-bar-mode -1) ;; small border without scroll bar > > + (when (and brief-turn-off-scroll-bar-mode > > + (fboundp #'scroll-bar-mode)) > > In which circumstance could `scroll-bar-mode` not be defined? > > > + (scroll-bar-mode -1) ;; small border without scroll bar > > + (setq-default scroll-bar-mode -1)) > > According to its doc, the `scroll-bar-mode` variable can take values > `nil`, `left`, and `right`. What do you intend to get by setting it to -1? > > > Stefan > > -- Best regards, Luke Lee --0000000000009710fb05f390c5ad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> The arg to `fboundp` is a symbol not a function (e.g.= it can't
> be a (lambda ...) for example)
That's a good p= oint, modification reverted.

> (<=3D 27 emacs= -major-version)
Nice, modified likewise.

= > Doesn't (scroll-bar-mode -1) do that already?
You're right,= corrected as well as some others.
Thanks!

On Mon, 30 Jan 2023 at 10:= 58, Stefan Monnier <monnier@= iro.umontreal.ca> wrote:
> branch: externals/brief
> commit 362d6296717af611be20cb56592d495c01ea7a00
> Author: Luke Lee <luke@gauss>
> Commit: Luke Lee <luke@gauss>

Please try and use a valid email as commit identifier.

> @@ -457,8 +461,9 @@
>=C2=A0 ;; backward compatibility issues.
>=C2=A0 ;;(require 'replace)
>=C2=A0
> -(defconst brief-version "5.87"
> -=C2=A0 "The version of this Brief emulator.")
> +;;;###autoload
> +(defconst brief-version "5.88.22"
> +=C2=A0 "Current version of this Brief editor mode/emulator."= ;)

Why autoload?

> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (fboundp 'save-mark= -and-excursion)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (fboundp #'save-mar= k-and-excursion)))

The arg to `fboundp` is a symbol not a function (e.g. it can't be
a (lambda ...) for example), so I think #' is ill-advised.
It works fine, in practice, so it's somewhat of a philosophical issue.<= br>
> +=C2=A0 (when (and (version<=3D "27.0" emacs-version)

I understand efficiency is not a major issue here, but

=C2=A0 =C2=A0 (<=3D 27 emacs-major-version)

works just as well :-)

> -=C2=A0 (scroll-bar-mode -1)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0;; small border without scroll bar
> +=C2=A0 (when (and brief-turn-off-scroll-bar-mode
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(fboundp #'scroll= -bar-mode))

In which circumstance could `scroll-bar-mode` not be defined?

> +=C2=A0 =C2=A0 (scroll-bar-mode -1)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0;; small border without scroll bar
> +=C2=A0 =C2=A0 (setq-default scroll-bar-mode -1))

According to its doc, the `scroll-bar-mode` variable can take values
`nil`, `left`, and `right`.=C2=A0 What do you intend to get by setting it t= o -1?


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan



--
Best regards,
Luke Lee

--0000000000009710fb05f390c5ad--