From: Federico Tedin <federicotedin@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Unit tests and lexical-binding for Tempo
Date: Tue, 21 May 2019 13:30:26 -0300 [thread overview]
Message-ID: <CAA8GjPmXVRcLdemdgbpco0zYWCAcCRGDuy3nUztsSCdDZDD25Q@mail.gmail.com> (raw)
In-Reply-To: <87ef4r7ucc.fsf@tcd.ie>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Looks perfect, thanks.
On Tue, 21 May 2019 at 11:31 Basil L. Contovounesios <contovob@tcd.ie>
wrote:
> Federico Tedin <federicotedin@gmail.com> writes:
>
> > Good catch, sorry about that. The correct header should use "Federico
> > Tedin <federicotedin@gmail.com>", like you mentioned.
>
> No worries. I took the liberties of extending the commit message to
> reference this discussion and mention the other variables which were
> switched to defvar-local, and shortening the docstring of
> tempo-tempo-user-elements-test to more closely follow the conventions in
> (info "(elisp) Documentation Tips"), and pushed to master[1]. Let me
> know if I messed anything up.
>
> [1: eb2e9a2ca2]: Use lexical-binding in tempo.el and add tests
> 2019-05-21 15:23:23 +0100
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eb2e9a2ca29f7d5e3b97709e9eca14fa5556ac63
>
> Thanks,
>
> --
> Basil
>
[-- Attachment #2: Type: text/html, Size: 1547 bytes --]
prev parent reply other threads:[~2019-05-21 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 19:00 [PATCH] Unit tests and lexical-binding for Tempo Federico Tedin
2019-05-14 0:49 ` Basil L. Contovounesios
2019-05-14 21:44 ` Federico Tedin
2019-05-20 15:26 ` Basil L. Contovounesios
2019-05-20 19:32 ` Federico Tedin
2019-05-21 14:30 ` Basil L. Contovounesios
2019-05-21 16:30 ` Federico Tedin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8GjPmXVRcLdemdgbpco0zYWCAcCRGDuy3nUztsSCdDZDD25Q@mail.gmail.com \
--to=federicotedin@gmail.com \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.