From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.devel Subject: Re: master 3586fef: Make HIST arg of read-from-minibuffer work with buffer-local vars Date: Thu, 5 Dec 2019 17:50:48 +0100 Message-ID: References: <20191205093041.3243.23144@vcs0.savannah.gnu.org> <20191205093043.1A8E0209BE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="20878"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 05 17:53:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icuNa-0005Go-Cz for ged-emacs-devel@m.gmane.org; Thu, 05 Dec 2019 17:53:26 +0100 Original-Received: from localhost ([::1]:57522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icuNY-0004Ri-VR for ged-emacs-devel@m.gmane.org; Thu, 05 Dec 2019 11:53:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33693) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icuLI-0004BC-8I for emacs-devel@gnu.org; Thu, 05 Dec 2019 11:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icuLG-0000Tx-JH for emacs-devel@gnu.org; Thu, 05 Dec 2019 11:51:03 -0500 Original-Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]:44716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icuLF-0000Pg-Rk for emacs-devel@gnu.org; Thu, 05 Dec 2019 11:51:01 -0500 Original-Received: by mail-il1-x129.google.com with SMTP id z12so3558293iln.11 for ; Thu, 05 Dec 2019 08:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zFfUIuTGTHqvzwjpODbR+qiioi4qAvOEGJrSR9K6LkQ=; b=a9LyrzmsLAuIGJ3GdLTLngSczSxtxUOaJWNF258lZ/AAdpPwQcjzKWEO3RfcG48DrT RmXJP4PPVcnOTf/xYYy8jiNUDutSU3kCjKXlXS3S7hwSw8z11UvtzPPTezHhEgoxhCXu Zb3UeUkd05+EC8t8we2ck2TKrujPdLiAtiEenKPKLeCfbGoLqptOLhJ2uUKt6HQhSbg7 gLRw5gt71BmJL+uaFlhqHjCU/0s5EtX19tGmz1U+6Kdnr3lQKyOdfFJtICFM9D7CoGzE 7mr/L08VDel/qO58G5FUatWYzuRjjuB5I9zhfDji2AOOkviEwI3PhJosRUnIx96xXnS8 a25g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zFfUIuTGTHqvzwjpODbR+qiioi4qAvOEGJrSR9K6LkQ=; b=EpPMP1gTdH/V52U+Jjzht2OkMGDKIXgHo4MOB9LAWGm7/X2aisvwzEyIR056WHjBqg 5U22YYAh3pvoDmjM3mJtmwtuN2ErEj9C28a70ANfV2rbiqAmAbI4UtXQtiGmFSJk+Qzj xU4UIM+GWGN3V8WQxMIaeu8KQvGyXfhp38HL8czddQ9aZq4Wjsf/iZKS4J1Gl1Iu/R8M /HBGK0BubbCNtluudw9XKfcpPLIEA+UERt2GdFvwgPyxqGASQZP8QbQh155mJtC09NI2 Zt7jIFsICCyh0hXbBin0uqJt7szttk/2mWq3bz6cimXDMTrkzIuKVlSNUvk9CMwMld+I ebMA== X-Gm-Message-State: APjAAAXTnnbKgVHHQUwt2P1bB0svtOwRr7CVAwdVehWoyDjHEXKQyAag 5kmQp9cLeabXU/2G+ynY3Q5KsLm2CN1ABLYGoZk= X-Google-Smtp-Source: APXvYqy3dhYV4mE7NFkcXYmV2fHjHnw2OS8hz3Nv9z/StU7p1F0zMc1k81sPG+U/6VUOmW0yceUa3xsvY5CDA4t7z1c= X-Received: by 2002:a92:b68b:: with SMTP id m11mr9534283ill.207.1575564660590; Thu, 05 Dec 2019 08:51:00 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::129 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243161 Archived-At: > Note that this `add-to-history` call takes place at the very end of > read_minibuf, hence just *before* we return to previous_buffer. > Maybe a simpler option than the code above is to postpone the code > a little bit so that it takes place *after* we return to > previous_buffer. Hey Stefan, Would that mean moving the `add-to-history' call to after the final call to `unbind_to(count, val)'? - Fede