From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.devel Subject: Re: INSIDE_EMACS and Tramp (was: master f28166d: Copy INSIDE_EMACS env variable to subprocesses in Eshell (Bug#25496)) Date: Sat, 4 Apr 2020 16:53:18 +0200 Message-ID: References: <20200402230535.10490.95720@vcs0.savannah.gnu.org> <20200402230536.E0A3F20CDD@vcs0.savannah.gnu.org> <87lfndarwh.fsf_-_@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="118575"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 04 16:54:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jKkBP-000UkI-4Z for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Apr 2020 16:54:03 +0200 Original-Received: from localhost ([::1]:39276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKkBO-00032I-3l for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Apr 2020 10:54:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41342) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKkAt-0002Xl-8Y for emacs-devel@gnu.org; Sat, 04 Apr 2020 10:53:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKkAs-0008IR-6u for emacs-devel@gnu.org; Sat, 04 Apr 2020 10:53:31 -0400 Original-Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]:44806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKkAs-0008IH-2j for emacs-devel@gnu.org; Sat, 04 Apr 2020 10:53:30 -0400 Original-Received: by mail-io1-xd2f.google.com with SMTP id h6so984899iok.11 for ; Sat, 04 Apr 2020 07:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nmChFXvWs8u983HNDvz1NVCZRpeSPVhxflM3xv1bk0A=; b=JvfBksrcdmT0V9JNp8cWJQxvO4JZ8AijMu2c4dBC1bJ72LqkzbuOeSCVi3luBjxT50 jsdyrqGnl4KpiZcY41Rs6vMSmYb72C3DP7aAaRGm6QTQnuKIwerqNaVcTiVSw5RAks5f FZxGCQdFgqswfUI0c5s4lbEUs1z49a6oDcZK63gPx1jXLIK/JcGIrdbEBL9hE7eIbkuA IWT8dRfvw06r2DPVA4e4qgsEZKIat1PNpnami4tDkB6kjUNYdVQyzAtL8toBPfYpujr0 0SNFH7UD0LPsAMMmqJUwSs62gl+FSyb9AI6faJwopl6L8GuwwAXZEJAUrg6F2nv7lf+K E7Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nmChFXvWs8u983HNDvz1NVCZRpeSPVhxflM3xv1bk0A=; b=r9Jn0ZQ53I4nL+vFGK69Kg5DnSXYVY6IXSuzq/bAiVgwb67vvQqrVkxcflWBST6/VC aMKbnRqp4D3FOZgSa/R2b2c5VGJX3ifeuyhYtUToosdfLNC0XRVu+14O+HSDSgmurxWL 4dS09pl5x3LJQk9rQjf4ShRzt4MgpTrxzEduR/NyScZwOsV/Aj9pnDIO/Wwie2tLE2uw /y59bBQJuq8EAOpU1XcJ2bQ1q7GvW9FhhXNdxCgCB36Zb3N5LqJ6jnZtGEgXLgsY0n56 LJvW5AI6bqeJeQEZZhfgnXxP1d5aOoUtdwjiPU00lgIpjtsiJRDKbdiIgRQe4kumeml4 b2kg== X-Gm-Message-State: AGi0PuZ1eRZ128/95iC9OT4h7GmsPA5qTUgrDfpSSQHlvYeQDHB+YA5m F42/cO1ZgKUlEAKxaaTZ+ynnY3WbAbzYnk+PIPU= X-Google-Smtp-Source: APiQypJhDLrOxjxtwtN0imy8e0RtbRjSRT2lWl8WQUtV1CYnJcayrfxfGud+oqbP/mo7Ou6g33V4j4KTUUJB4/FhhWc= X-Received: by 2002:a05:6602:14c5:: with SMTP id b5mr1271289iow.148.1586012009174; Sat, 04 Apr 2020 07:53:29 -0700 (PDT) In-Reply-To: <87lfndarwh.fsf_-_@gmx.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d2f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246405 Archived-At: Hey Michael, some questions: > --8<---------------cut here---------------start------------->8--- > (let ((default-directory "/ssh::")) > (shell-command-to-string "echo $INSIDE_EMACS")) > --8<---------------cut here---------------end--------------->8--- > > you get "28.0.50,tramp:2.5.0-pre". But if you run in an eshell buffer Would it make sense to change this to "28.0.50,,tramp:2.5.0-pre" (notice the extra comma), or "28.0.50,shell,tramp:2.5.0-pre"? This way, the second element in the list will always be the shell type, and the optional third will be the Tramp version. Though I'm not sure if "shell" would correspond to "shell-command-to-string". > --8<---------------cut here---------------start------------->8--- > ~/src/emacs $ cd /ssh:: > /ssh:detlef:/home/albinus $ *echo $INSIDE_EMACS > --8<---------------cut here---------------end--------------->8--- > > you get "28.0.50,eshell". Tramp's setting is overwritten. > > Shouldn't the specifics be merged, so that we get > "28.0.50,eshell,tramp:2.5.0-pre"? > > Same for the other packages setting INSIDE_EMACS, like compile, comint, > term and epg. I could maybe start working on adding this for Eshell (now that I more or less know how it internally handles variables) if you think that makes sense. - Fede