From: Federico Tedin <federicotedin@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: INSIDE_EMACS and Tramp (was: master f28166d: Copy INSIDE_EMACS env variable to subprocesses in Eshell (Bug#25496))
Date: Sat, 4 Apr 2020 16:53:18 +0200 [thread overview]
Message-ID: <CAA8GjPky=J-GVRwLNQu_AX2z857LLjrFuj-F2vpSopxrGGeRTQ@mail.gmail.com> (raw)
In-Reply-To: <87lfndarwh.fsf_-_@gmx.de>
Hey Michael, some questions:
> --8<---------------cut here---------------start------------->8---
> (let ((default-directory "/ssh::"))
> (shell-command-to-string "echo $INSIDE_EMACS"))
> --8<---------------cut here---------------end--------------->8---
>
> you get "28.0.50,tramp:2.5.0-pre". But if you run in an eshell buffer
Would it make sense to change this to "28.0.50,,tramp:2.5.0-pre"
(notice the extra comma), or "28.0.50,shell,tramp:2.5.0-pre"?
This way, the second element in the list will always be the shell
type, and the optional third will be the Tramp version. Though I'm
not sure if "shell" would correspond to "shell-command-to-string".
> --8<---------------cut here---------------start------------->8---
> ~/src/emacs $ cd /ssh::
> /ssh:detlef:/home/albinus $ *echo $INSIDE_EMACS
> --8<---------------cut here---------------end--------------->8---
>
> you get "28.0.50,eshell". Tramp's setting is overwritten.
>
> Shouldn't the specifics be merged, so that we get
> "28.0.50,eshell,tramp:2.5.0-pre"?
>
> Same for the other packages setting INSIDE_EMACS, like compile, comint,
> term and epg.
I could maybe start working on adding this for Eshell (now that I more
or less know how it internally handles variables) if you think that
makes sense.
- Fede
next prev parent reply other threads:[~2020-04-04 14:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200402230535.10490.95720@vcs0.savannah.gnu.org>
[not found] ` <20200402230536.E0A3F20CDD@vcs0.savannah.gnu.org>
2020-04-03 8:35 ` INSIDE_EMACS and Tramp (was: master f28166d: Copy INSIDE_EMACS env variable to subprocesses in Eshell (Bug#25496)) Michael Albinus
2020-04-04 14:53 ` Federico Tedin [this message]
2020-04-04 15:10 ` INSIDE_EMACS and Tramp Michael Albinus
2020-04-04 20:13 ` Federico Tedin
2020-04-13 9:07 ` Michael Albinus
2020-04-17 20:16 ` Federico Tedin
2020-05-02 14:54 ` Michael Albinus
2020-05-02 15:39 ` Eli Zaretskii
2020-05-02 16:04 ` Michael Albinus
2020-05-02 16:17 ` Eli Zaretskii
2020-05-02 16:16 ` Eli Zaretskii
2020-05-02 17:20 ` Stefan Monnier
2020-05-03 12:33 ` Michael Albinus
2020-05-03 14:51 ` Stefan Monnier
2020-05-03 16:08 ` Michael Albinus
2020-05-03 20:54 ` Stefan Monnier
2020-05-04 7:08 ` Michael Albinus
2020-05-04 8:47 ` Michael Albinus
2020-05-04 15:38 ` Stefan Monnier
2020-05-04 16:11 ` Michael Albinus
2020-05-03 14:52 ` Federico Tedin
2020-05-03 16:19 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8GjPky=J-GVRwLNQu_AX2z857LLjrFuj-F2vpSopxrGGeRTQ@mail.gmail.com' \
--to=federicotedin@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.