From: Federico Tedin <federicotedin@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 32549@debbugs.gnu.org
Subject: bug#32549: Allow passing custom options to vc-git-grep
Date: Sat, 1 Sep 2018 18:55:15 -0300 [thread overview]
Message-ID: <CAA8GjPknSmRwA23FoNk3jAk0wxHamzond4M6GpPK+DbZYNUumQ@mail.gmail.com> (raw)
In-Reply-To: <CAA8GjPmqnKSBU34cvL0uPAmRsAnSPOvjK18i9A4gtcRxjZKD2g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 89 bytes --]
I'm attaching a patch with the implementation of the new feature
(vc-git-grep-template).
[-- Attachment #2: 0001-Add-variable-vc-git-grep-template.patch --]
[-- Type: text/x-diff, Size: 2135 bytes --]
From 55243e6e72414ce35058be2ad45a8ca6643ed14a Mon Sep 17 00:00:00 2001
From: Federico Tedin <federicotedin@gmail.com>
Date: Sat, 1 Sep 2018 18:46:16 -0300
Subject: [PATCH 1/1] Add variable vc-git-grep-template
* lisp/vc/vc-git.el (vc-git-grep-template): New variable, allows
changing the default arguments passed to git-grep when using
'vc-git-grep'.
* etc/NEWS: Mention 'vc-git-grep-template'. (Bug#32549)
---
etc/NEWS | 4 ++++
lisp/vc/vc-git.el | 10 +++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/etc/NEWS b/etc/NEWS
index 1fe662ffff..fa600c67b5 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -277,6 +277,10 @@ still be used if it exists.) Set the variable to nil to get the
previous behavior of always creating a buffer that visits a ChangeLog
file.
+*** New customizable variable 'vc-git-grep-template'.
+This new variable allows customizing the default arguments passed to
+git-grep when 'vc-git-grep' is used.
+
** diff-mode
*** Hunks are now automatically refined by default.
To disable it, set the new defcustom 'diff-font-lock-refine' to nil.
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 96c2f38af4..567f00104b 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -179,6 +179,14 @@ vc-git-log-output-coding-system
:type '(coding-system :tag "Coding system to decode Git log output")
:version "25.1")
+(defcustom vc-git-grep-template "git --no-pager grep -n -e <R> -- <F>"
+ "The default command to run for \\[vc-git-grep].
+The following place holders should be present in the string:
+ <F> - file names and wildcards to search.
+ <R> - the regular expression searched for."
+ :type 'string
+ :version "27.1")
+
;; History of Git commands.
(defvar vc-git-history nil)
@@ -1449,7 +1457,7 @@ vc-git-grep
(setq command nil))
(setq dir (file-name-as-directory (expand-file-name dir)))
(setq command
- (grep-expand-template "git --no-pager grep -n -e <R> -- <F>"
+ (grep-expand-template vc-git-grep-template
regexp files))
(when command
(if (equal current-prefix-arg '(4))
--
2.17.1
next prev parent reply other threads:[~2018-09-01 21:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 23:03 bug#32549: Allow passing custom options to vc-git-grep Federico Tedin
2018-08-27 23:20 ` Noam Postavsky
2018-08-28 2:55 ` Federico Tedin
2018-08-28 3:52 ` Noam Postavsky
2018-08-28 23:01 ` Federico Tedin
2018-08-28 23:14 ` Noam Postavsky
2018-08-28 23:31 ` Federico Tedin
2018-08-29 0:45 ` Noam Postavsky
2018-08-29 0:54 ` Federico Tedin
2018-09-01 21:55 ` Federico Tedin [this message]
2018-09-04 23:03 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8GjPknSmRwA23FoNk3jAk0wxHamzond4M6GpPK+DbZYNUumQ@mail.gmail.com \
--to=federicotedin@gmail.com \
--cc=32549@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.